Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completing noise #9

Merged
merged 5 commits into from
Oct 30, 2019
Merged

Completing noise #9

merged 5 commits into from
Oct 30, 2019

Conversation

noot
Copy link

@noot noot commented Sep 4, 2019

This PR completes the functionality of the protocol, however, still needs some clean-up

  • add lock to write to fix stream issues
  • clean up logging
  • add more integration tests

@codecov-io
Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #9 into master will increase coverage by 0.51%.
The diff coverage is 30.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   61.46%   61.98%   +0.51%     
==========================================
  Files           7        7              
  Lines        1064     1039      -25     
==========================================
- Hits          654      644      -10     
+ Misses        367      348      -19     
- Partials       43       47       +4
Impacted Files Coverage Δ
ik_handshake.go 0% <0%> (ø) ⬆️
ik/IK.noise.go 73.17% <0%> (ø) ⬆️
transport.go 85.71% <100%> (+4.76%) ⬆️
xx_handshake.go 41.78% <18.51%> (-4.78%) ⬇️
protocol.go 67.13% <50%> (-11.32%) ⬇️
crypto.go 48.71% <0%> (-5.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ed9ec...1d6cd71. Read the comment docs.

@hinshun
Copy link

hinshun commented Sep 7, 2019

Hi @noot , I'm currently working on a libp2p benchmarking infra project. I was able to get a simple peer-to-peer transfer working, but the full benchmark is having issues being completed, which indicates there's a bug of some sort.

I've included all the reproduction steps in the PR: Netflix/p2plab#30

@noot
Copy link
Author

noot commented Sep 8, 2019

Hey @hinshun , thanks for commenting, there most likely is a bug somewhere in the code, it's still in relatively early stages and hasn't been reviewed yet. I'll take a look at your issue and get back to you soon.

@noot noot merged commit dff6fbe into master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants