-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include EL client info in graffiti #6753
Conversation
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General approach of having the default moved from validator client to beacon node looks good to me, just need to make sure to always respect graffiti if explicitly set by user.
I haven't looked at the spec PR, will do more detailed review once the high-level concerns are addressed.
Co-authored-by: Cayman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6753 +/- ##
============================================
- Coverage 62.49% 62.49% -0.01%
============================================
Files 576 576
Lines 61190 61199 +9
Branches 2141 2138 -3
============================================
+ Hits 38243 38245 +2
- Misses 22908 22915 +7
Partials 39 39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - could update PR description to reflect latest changes
🎉 This PR is included in v1.21.0 🎉 |
This PR shifts the responsibility of setting the default graffiti from
validator
tobeacon-node
and also definesengine_getClientVersionV1
.Due to
validator
package no longer determines default graffiti, graffitiValidatorStore
is now marked as optional (typestring | undefined
). This implies produce block endpoints in validator api accepts optional graffiti andgetGraffiti
in key manager api now may throw error if no graffiti is available for the queried pubkey.Default graffiti will be used during produceBlock api call when the block graffiti is undefined and
private
flag is unset. It is composed bygetDefaultGraffiti
which requires consensus client version and execution client version. Execution client version is retrieved by callingengine_getClientVersionV1
during execution engine start up and when updating execution engine state. The response is cached inclientVersion
within execution engine.Closes #6463