-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getUserProfile() default fields #166
Open
drezo
wants to merge
10
commits into
Charca:master
Choose a base branch
from
drezo:feature/default-fields
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c23b53e
set default fields
drezo 2a738d1
update jsdoc
drezo 24a438e
pass variable
drezo f922f42
change "reduce" to "join" 😁
drezo 098c1e1
change example
drezo 785f798
Change README.md
drezo dee0790
set default variable
drezo 7e6729b
Remove idea code style
drezo 74ea7b1
update .gitignore (ignore IDE files)
drezo c9d493f
Merge remote-tracking branch 'origin/feature/default-fields' into fea…
drezo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,9 @@ logs | |
*.log | ||
npm-debug.log* | ||
|
||
#Idea Files | ||
.idea/ | ||
|
||
# Runtime data | ||
pids | ||
*.pid | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -332,11 +332,20 @@ class BootBot extends EventEmitter { | |
|
||
/** | ||
* Returns a Promise that contains the user's profile information. | ||
* Default fields: id, name, first_name, last_name, profile_pic | ||
* Additional fields: locale, timezone, gender | ||
* Link: https://developers.facebook.com/docs/messenger-platform/identity/user-profile | ||
* @param {String} userId | ||
* @param {Array} fields Additions fields (ex.: locale/timezone/gender). | ||
* @returns {Promise} | ||
*/ | ||
getUserProfile(userId) { | ||
const url = `https://graph.facebook.com/${this.graphApiVersion}/${userId}?fields=first_name,last_name,profile_pic,locale,timezone,gender&access_token=${this.accessToken}`; | ||
getUserProfile(userId, fields) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we give |
||
const defaultFields = ['id', 'name', 'first_name', 'last_name', 'profile_pic']; | ||
if (!Array.isArray(fields)) { | ||
throw new Error('Fields is supposed to be an array'); | ||
} else Array.prototype.push.apply(defaultFields, fields.map(field => field.trim())); | ||
const mergeFields = defaultFields.join(','); | ||
const url = `https://graph.facebook.com/${this.graphApiVersion}/${userId}?fields=${mergeFields}&access_token=${this.accessToken}`; | ||
return fetch(url) | ||
.then(res => res.json()) | ||
.catch(err => console.log(`Error getting user profile: ${err}`)); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we should change this description. The default value of the
fields
param is not['id', 'name', ... ]
, it's an empty array. When you specify fields, you're not overwriting this default value, you're extending it. I think we should either change the behavior to allow specifying/overwriting all fields, or change this description and maybe the param name toextraFields
so that it's clear that you're extending the default. What do you think?