Skip to content

Commit

Permalink
Merge pull request #4782 from josephrocca/patch-1
Browse files Browse the repository at this point in the history 
Fix web url
  • Loading branch information
@lloydzhou
lloydzhou authored Jul 1, 2024
2 parents c359b30 + f3b972e commit ce3b6a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ One-Click to get a well-designed cross-platform ChatGPT web UI, with GPT3, GPT4

[网页版](https://app.nextchat.dev/) / [客户端](https://github.com/Yidadaa/ChatGPT-Next-Web/releases) / [反馈](https://github.com/Yidadaa/ChatGPT-Next-Web/issues)

[web-url]: https://chatgpt.nextweb.fun
[web-url]: https://app.nextchat.dev/
[download-url]: https://github.com/Yidadaa/ChatGPT-Next-Web/releases
[Web-image]: https://img.shields.io/badge/Web-PWA-orange?logo=microsoftedge
[Windows-image]: https://img.shields.io/badge/-Windows-blue?logo=windows
Expand Down

3 comments on commit ce3b6a0

@bygsn
Copy link

@bygsn bygsn commented on ce3b6a0 Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lloydzhou Hi, I am the submitter of PR #4902 (Export sync config). I noticed that my PR encountered some issues during the checks, especially the Vercel deployment preview requiring authorization. I have a few questions:

  1. I see the prompt "Authorization required to deploy". Is this normal? As an external contributor, what do I need to do to resolve this issue?

  2. Apart from this authorization issue, do you see any other aspects of my PR that need modification or improvement?

  3. As a new contributor, are there any specific points I should pay attention to when submitting PRs?

I greatly appreciate your time and guidance. If you need me to make any changes or provide more information, please let me know, and I will address it promptly.

Thank you again for your help!

@Dogtiti
Copy link
Member

@Dogtiti Dogtiti commented on ce3b6a0 Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KILL4M
Thank you for contributing the PR. Actually, authorizing Vercel preview means that some changes need to be deployed to Vercel for testing before merging. If the tests pass without issues, the changes will be merged. However, since your PR does not involve functional changes, it is not necessary to deploy to Vercel this time. We believe it can be merged directly.

@bygsn
Copy link

@bygsn bygsn commented on ce3b6a0 Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KILL4M Thank you for contributing the PR. Actually, authorizing Vercel preview means that some changes need to be deployed to Vercel for testing before merging. If the tests pass without issues, the changes will be merged. However, since your PR does not involve functional changes, it is not necessary to deploy to Vercel this time. We believe it can be merged directly.

Thank you very much for your reply and guidance.

Regarding this PR that can be directly merged, I have a few questions, and I hope I'm not disturbing you:

  1. Do you have any idea when this PR might be processed?
  2. Should I patiently wait, or do I need to find a specific person to assist with the merge?
  3. If convenient, could you consider processing it sooner to reduce potential code conflicts?

If there's anything I can assist with, please don't hesitate to let me know.

Thank you again for your time.

Please sign in to comment.