Skip to content

Commit

Permalink
Merge pull request #4771 from yangxiang92/main
Browse files Browse the repository at this point in the history 
fix: make env PROXY_URL avaliable in Docker container.
  • Loading branch information
@Dean-YZG
Dean-YZG authored May 27, 2024
2 parents 3866448 + bf3bc3c commit da2e237
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ CMD if [ -n "$PROXY_URL" ]; then \
echo "[ProxyList]" >> $conf; \
echo "$protocol $host $port" >> $conf; \
cat /etc/proxychains.conf; \
proxychains -f $conf "node server.js --host 0.0.0.0"; \
proxychains -f $conf node server.js --host 0.0.0.0; \
else \
node server.js; \
fi

1 comment on commit da2e237

@bygsn
Copy link

@bygsn bygsn commented on da2e237 Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-YZG Hi,

I am the submitter of PR #4902 (Export sync config). I noticed that my PR encountered some issues during the checks, especially the Vercel deployment preview requiring authorization. I have a few questions:

  1. I see the prompt "Authorization required to deploy". Is this normal? As an external contributor, what do I need to do to resolve this issue?

  2. Apart from this authorization issue, do you see any other aspects of my PR that need modification or improvement?

  3. As a new contributor, are there any specific points I should pay attention to when submitting PRs?

I greatly appreciate your time and guidance. If you need me to make any changes or provide more information, please let me know, and I will address it promptly.

Thank you again for your help!

Please sign in to comment.