feat: add relative path support #1576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunnyLimc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#720
UPDATE: Because this implementation is not elegant and may lead to bugs, I am closing the pull request
Add support for relative paths to the application
As this project uses react-router-dom as the routing component (in which the URL uses "#" to achieve page routing functionality), changing the route does not actually change the directory of the page.
We can use some tricks to support relative paths without requiring users to modify any configuration files on the proxy server side for application deployment.
Until a better method is found, some links that can only use absolute paths need to be discarded.
WARNING: If the routing implementation needs to be changed in later development, this change needs to be reverted.