Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #4779

Closed
wants to merge 10 commits into from
Closed

update #4779

wants to merge 10 commits into from

Conversation

feiosme
Copy link

@feiosme feiosme commented May 26, 2024

Summary by CodeRabbit

  • New Features

    • Added new custom model configurations.
    • Introduced new models (glm-4 and glm-3-turbo) with provider details.
  • Enhancements

    • Updated default model to glm-4.
    • Increased historyMessageCount to 8 for better context retention.
    • Increased compressMessageLengthThreshold to 16384 for handling longer messages.
  • Localization

    • Enhanced Chinese localization with additional information about data confidentiality.

Copy link

vercel bot commented May 26, 2024

@feiosme is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 26, 2024

Walkthrough

The recent updates introduce a new CUSTOM_MODELS variable in the .env.template file, expand the DEFAULT_MODELS and DEFAULT_CONFIG objects with new models and configurations, and enhance the BotHello message in the Chinese localization file to emphasize data confidentiality. Additionally, new constants and model configurations have been added to support these changes.

Changes

Files Change Summaries
.env.template Added CUSTOM_MODELS variable with custom model configurations.
app/constant.ts Added ZHIPU_BASE_URL constant and new models (glm-4 and glm-3-turbo).
app/locales/cn.ts Expanded BotHello message to include data confidentiality information.
app/store/config.ts Updated DEFAULT_CONFIG with new model, top_p, max_tokens, and other settings.

In the world of code, a rabbit's delight,
New models and configs come to light.
With glm-4 and glm-3-turbo in the mix,
And a message on data, clear and fixed.
Hop along, dear coder, the future's bright! 🌟

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

  • Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
  • Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
  • Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

  • Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
  • Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
  • High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
  • Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai redo review to redo the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@feiosme feiosme closed this May 26, 2024
Copy link
Contributor

Your build has completed!

Preview deployment

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range and nitpick comments (3)
app/store/config.ts (1)

Line range hint 73-73: Replace isNaN with Number.isNaN for safer type checking.

- if (isNaN(x)) {
+ if (Number.isNaN(x)) {
app/constant.ts (1)

Line range hint 59-59: Use template literals for better readability and maintainability.

- export const UNFINISHED_INPUT = (id: string) => "unfinished-input-" + id;
+ export const UNFINISHED_INPUT = (id: string) => `unfinished-input-${id}`;

Also applies to: 97-97

app/locales/cn.ts (1)

Line range hint 94-96: Use let or const instead of var for variable declarations, and prefer template literals over string concatenation.

- var inputHints = `${submitKey} 发送`;
+ let inputHints = `${submitKey} 发送`;

Also applies to: 483-483

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3866448 and f486479.
Files selected for processing (4)
  • .env.template (1 hunks)
  • app/constant.ts (2 hunks)
  • app/locales/cn.ts (1 hunks)
  • app/store/config.ts (1 hunks)
Additional Context Used
Biome (13)
app/constant.ts (2)

59-59: Template literals are preferred over string concatenation.


97-97: Do not use template literals if interpolation and special-character handling are not needed.

app/locales/cn.ts (7)

103-105: Template literals are preferred over string concatenation.


290-290: Unexpected any. Specify a different type.


351-351: Unexpected any. Specify a different type.


352-352: Unexpected any. Specify a different type.


483-483: Template literals are preferred over string concatenation.


483-483: Unexpected any. Specify a different type.


94-96: Use let or const instead of var.

app/store/config.ts (4)

46-46: Unexpected any. Specify a different type.


166-166: Unexpected any. Specify a different type.


1-1: All these imports are only used as types.


73-73: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.

Additional comments not posted (1)
app/locales/cn.ts (1)

363-364: Ensure the new message aligns with privacy policies and is clear to users.

@@ -47,3 +47,4 @@ ENABLE_BALANCE_QUERY=
# If you want to disable parse settings from url, set this value to 1.
DISABLE_FAST_LINK=

CUSTOM_MODELS=+glm-3-turbo,+glm-4,+ERNIE-Bot=文心一言3.5,+ERNIE-Bot-turbo=文心一言3.5turbo,+ERNIE-Bot-4,+BLOOMZ-7B,+Qianfan-Chinese-Llama-2-7B,+Qianfan-Chinese-Llama-2-13B,+ChatGLM2-6B-32K,+AquilaChat-7B,+SQLCoder-7B,+CodeLlama-7B-Instruct,+XuanYuan-70B-Chat-4bit,+ChatLaw,+Yi-34B-Chat,+Mixtral-8x7B-Instruct
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more structured format for CUSTOM_MODELS to enhance maintainability.

- CUSTOM_MODELS=+glm-3-turbo,+glm-4,+ERNIE-Bot=文心一言3.5,+ERNIE-Bot-turbo=文心一言3.5turbo,+ERNIE-Bot-4,+BLOOMZ-7B,+Qianfan-Chinese-Llama-2-7B,+Qianfan-Chinese-Llama-2-13B,+ChatGLM2-6B-32K,+AquilaChat-7B,+SQLCoder-7B,+CodeLlama-7B-Instruct,+XuanYuan-70B-Chat-4bit,+ChatLaw,+Yi-34B-Chat,+Mixtral-8x7B-Instruct
+ CUSTOM_MODELS=glm-3-turbo,glm-4,ERNIE-Bot=文心一言3.5,ERNIE-Bot-turbo=文心一言3.5turbo,ERNIE-Bot-4,BLOOMZ-7B,Qianfan-Chinese-Llama-2-7B,Qianfan-Chinese-Llama-2-13B,ChatGLM2-6B-32K,AquilaChat-7B,SQLCoder-7B,CodeLlama-7B-Instruct,XuanYuan-70B-Chat-4bit,ChatLaw,Yi-34B-Chat,Mixtral-8x7B-Instruct

Committable suggestion was skipped due low confidence.

@@ -46,15 +46,15 @@ export const DEFAULT_CONFIG = {
models: DEFAULT_MODELS as any as LLMModel[],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify a more precise type instead of any to enhance type safety.

- models: DEFAULT_MODELS as any as LLMModel[],
+ models: DEFAULT_MODELS as LLMModel[],

Also applies to: 166-166


Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
models: DEFAULT_MODELS as any as LLMModel[],
models: DEFAULT_MODELS as LLMModel[],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant