Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vision model check in utils.ts #4941

Closed
wants to merge 1 commit into from

Conversation

wolf-joe
Copy link

@wolf-joe wolf-joe commented Jul 7, 2024

compatible with openrouter model format, see

Summary by CodeRabbit

  • New Features
    • Added support for two new model versions: "gemini-pro-1.5" and "gemini-flash-1.5".

Copy link

vercel bot commented Jul 7, 2024

@wolf-joe is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 7, 2024

Walkthrough

The update enhances the isVisionModel function in app/utils.ts by including two new model versions, "gemini-pro-1.5" and "gemini-flash-1.5". This allows the function to recognize these additional models as vision models, ensuring compatibility and support within the application for these new versions.

Changes

Files Change Summary
app/utils.ts Added two new model versions ("gemini-pro-1.5" and "gemini-flash-1.5") to the isVisionModel function.

Poem

Across the fields where code does play,
Two new models join the fray,
Gemini-pro and flash, they say,
Enhance our visions, clear as day.
With every tweak, our code's array,
Enriching features, come what may!
✨🐇💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7218f13 and 7d61b20.

Files selected for processing (1)
  • app/utils.ts (1 hunks)
Additional comments not posted (1)
app/utils.ts (1)

258-259: LGTM!

The new model versions "gemini-pro-1.5" and "gemini-flash-1.5" have been correctly added to the visionKeywords array.

app/utils.ts Show resolved Hide resolved
@lloydzhou lloydzhou added the question Further information is requested label Jul 9, 2024
@wolf-joe wolf-joe requested a review from Dogtiti July 11, 2024 03:35
@Dogtiti
Copy link
Member

Dogtiti commented Jul 15, 2024

I believe that using a custom model feature is more appropriate here. We can't keep adding identical models indefinitely if they are just named differently by different providers.

@wolf-joe
Copy link
Author

I believe that using a custom model feature is more appropriate here. We can't keep adding identical models indefinitely if they are just named differently by different providers.

The issue is that when the model is set to gemini-pro-1.5, even if it is displayed as gemini-1.5-pro through a custom model, the image upload feature cannot be used.

@lloydzhou
Copy link
Contributor

这个现在可以通过CUSTOM_MODELS配置使用,所以,不需要往内置的模型添加这种不在官方列表中的模型

@lloydzhou lloydzhou closed this Jul 25, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


This can now be configured through CUSTOM_MODELS, so there is no need to add this model that is not in the official list to the built-in model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants