hotfix: old AZURE_URL config error: "DeploymentNotFound". #4945 #4930 #4953
Conversation
|
@lloydzhou is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe updates encompass enhancing model handling logic, improving Azure-specific configurations, and refining provider name consistency. Specifically, the changes optimize model name and deployment ID management, update documentation to reflect these enhancements, and correct the provider name in the configuration file. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- app/api/common.ts (1 hunks)
- app/utils/model.ts (1 hunks)
Additional context used
Biome
app/utils/model.ts
[error] 47-47: The assignment should not be in an expression.
The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.(lint/suspicious/noAssignInExpressions)
Additional comments not posted (6)
app/utils/model.ts (5)
50-59: Improvement: Refactored logic for finding and setting model availability.The refactored logic improves readability and maintainability by using destructuring assignment and refining the condition for finding the model.
Line range hint
61-70:
No changes detected.The function
collectModelTableWithDefaultModeldoes not have any changes.Tools
Biome
[error] 47-47: The assignment should not be in an expression.
The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.(lint/suspicious/noAssignInExpressions)
Line range hint
72-80:
No changes detected.The function
collectModelsdoes not have any changes.Tools
Biome
[error] 47-47: The assignment should not be in an expression.
The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.(lint/suspicious/noAssignInExpressions)
Line range hint
82-90:
No changes detected.The function
collectModelsWithDefaultModeldoes not have any changes.Tools
Biome
[error] 47-47: The assignment should not be in an expression.
The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.(lint/suspicious/noAssignInExpressions)
Line range hint
92-99:
No changes detected.The function
isModelAvailableInServerdoes not have any changes.Tools
Biome
[error] 47-47: The assignment should not be in an expression.
The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.(lint/suspicious/noAssignInExpressions)
app/api/common.ts (1)
69-93: Improvement: Added logic for forward compatibility.The added logic improves forward compatibility by checking and replacing model names with deployment IDs in the path under certain conditions.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- README.md (2 hunks)
- README_CN.md (2 hunks)
Files skipped from review due to trivial changes (1)
- README.md
Additional comments not posted (2)
README_CN.md (2)
98-99: LGTM!The added note provides clear guidance on removing
{deploy-name}fromAZURE_URLif it is configured inCUSTOM_MODELS.
160-162: LGTM!The added syntax and example for configuring model and deployment names for Azure in
CUSTOM_MODELSare clear and useful.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor