Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 支持百度千帆SDK #5095

Closed
wants to merge 7 commits into from

Conversation

dl102306
Copy link

@dl102306 dl102306 commented Jul 23, 2024

💻 变更类型 | feat

🔀 变更说明 | Description of Change

接入百度千帆SDK

千帆SDK
提供了丰富的能力,包括对话Chat、续写Completions、向量Embeddings、插件应用、Prompt工程、模型服务、管理、调优及数据管理等能力

Summary by CodeRabbit

  • New Features

    • Introduced new environment variables for integrating with the Baidu Qianfan service.
    • Enhanced chat functionality by leveraging the Baidu Qianfan SDK for improved API interactions.
  • Chores

    • Added the @baiducloud/qianfan package to project dependencies to support new features.

Copy link

vercel bot commented Jul 23, 2024

Someone is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 23, 2024

Walkthrough

The recent changes enhance the application by integrating the Baidu Qianfan service. New environment variables for access keys were added, and the chat functionality now utilizes the @baiducloud/qianfan SDK instead of a manual fetch implementation. This transition not only improves maintainability but also enriches the project's dependencies, allowing for more robust interactions with the Baidu API.

Changes

Files Change Summary
.env.template Added environment variables QIANFAN_AK and QIANFAN_SK for Baidu Qianfan service.
app/client/platforms/baidu.ts Refactored ErnieApi class to use ChatCompletion from @baiducloud/qianfan SDK for chat requests, improving API interaction.
package.json Updated dependency @baiducloud/qianfan to version 0.1.6 for enhanced functionality.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant QianfanAPI

    User->>App: Sends chat request
    App->>QianfanAPI: Uses ChatCompletion SDK to send request
    QianfanAPI-->>App: Returns chat response
    App-->>User: Displays response
Loading

Poem

🐇 In the meadow where rabbits play,
New keys unlock a brighter day!
With Qianfan’s chat, oh what a treat,
Conversations flow, oh so sweet!
Hopping 'round with endless cheer,
Our code dances, the future is near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
.env.template (1)

71-73: LGTM! Consider adding comments for the new environment variables.

The new environment variables QIANFAN_AK and QIANFAN_SK are correctly added. To improve clarity, consider adding comments explaining their purpose.

+ # Baidu Qianfan Access Key (required)
QIANFAN_AK=
+ # Baidu Qianfan Secret Key (required)
QIANFAN_SK=
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 00be2be and 073e872.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (3)
  • .env.template (1 hunks)
  • app/client/platforms/baidu.ts (2 hunks)
  • package.json (1 hunks)
Additional comments not posted (3)
package.json (1)

47-48: LGTM!

The new dependency @baiducloud/qianfan has been correctly added to the dependencies section.

app/client/platforms/baidu.ts (2)

10-10: Import statement for ChatCompletion looks good.

The import statement for ChatCompletion from @baiducloud/qianfan has been correctly added.


251-268: LGTM! Ensure the new SDK implementation handles all edge cases.

The new implementation using the ChatCompletion class from the @baiducloud/qianfan SDK looks good. Ensure that it correctly handles all edge cases and errors.

@lloydzhou lloydzhou requested a review from Dogtiti July 25, 2024 09:33
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 073e872 and f75156b.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (1)
  • package.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • package.json

Copy link
Contributor

Your build has completed!

Preview deployment

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
app/client/platforms/baidu.ts (1)

145-148: Improve error handling with more context.

Consider providing more context in the error message to aid in debugging.

-  console.log("[Request] failed to make a chat request", e);
+  console.log("[Request] failed to make a chat request to Baidu API with payload:", requestPayload, "Error:", e);
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f75156b and 40236fb.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (1)
  • app/client/platforms/baidu.ts (2 hunks)
Additional comments not posted (6)
app/client/platforms/baidu.ts (6)

5-5: LGTM!

The new import statement for ChatCompletion is necessary for the integration of the Baidu Qianfan SDK.


Line range hint 149-153:
LGTM!

The usage method is straightforward and does not require any changes.


Line range hint 155-157:
LGTM!

The models method is straightforward and does not require any changes.


120-127: Verify the correctness of access credentials retrieval.

Ensure that the baiduApiKey and baiduSecretKey are correctly retrieved from the state and are valid.

Verification successful

The retrieval of baiduApiKey and baiduSecretKey from the state is correctly implemented.

  • The values are initialized in app/store/access.ts.
  • They are accessed correctly in app/client/platforms/baidu.ts and other relevant files.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the retrieval of baiduApiKey and baiduSecretKey from the state.

# Test: Search for the state management code. Expect: Correct retrieval of baiduApiKey and baiduSecretKey.
rg --type typescript 'baiduApiKey|baiduSecretKey'

Length of output: 86


Script:

#!/bin/bash
# Description: Verify the retrieval of baiduApiKey and baiduSecretKey from the state.

# Test: Search for the state management code. Expect: Correct retrieval of baiduApiKey and baiduSecretKey.
rg 'baiduApiKey|baiduSecretKey' -A 3 -B 3

Length of output: 4860


124-126: Verify the correctness of base URL construction.

Ensure that the base URL is correctly constructed using the application's origin and the optional custom URL from the access store.


129-144: Verify the response handling logic.

Ensure that the response handling logic correctly processes the response from the client.chat() method.

@lloydzhou lloydzhou closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants