add fanyi add top tip #5470

mayfwl · 2024-09-19T09:00:08Z

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

vercel · 2024-09-19T09:00:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextchat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 7:23am

coderabbitai · 2024-09-19T09:00:15Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Dogtiti · 2024-09-19T09:06:40Z

app/components/auth.tsx

+
+  useEffect(() => {
+    // 检查 localStorage 中是否有标记
+    const bannerDismissed = localStorage.getItem("bannerDismissed");


https://github.com/ChatGPTNextWeb/ChatGPT-Next-Web/blob/main/app/utils.ts#L321

Dogtiti · 2024-09-19T09:07:09Z

app/icons/www-delete.svg

Dogtiti · 2024-09-19T11:11:50Z

app/components/auth.tsx

@@ -112,20 +113,21 @@ export function AuthPage() {
 function TopBanner() {
  const [isHovered, setIsHovered] = useState(false);
  const [isVisible, setIsVisible] = useState(true);
+  const storage = safeLocalStorage();


Dogtiti · 2024-09-19T11:12:13Z

app/components/auth.tsx

      setIsVisible(true); // 显示横幅
    } else if (bannerDismissed === "true") {
      // 如果标记为 "true"，则隐藏横幅
      setIsVisible(false);
    }
-  }, []);
+  }, [storage]);


不需要作为组件内部的依赖项初始化storage，只需要初始化一次不需要每次render都要初始化

github-actions · 2024-09-23T03:02:30Z

Your build has completed!

Preview deployment

Dogtiti · 2024-09-24T02:30:18Z

app/components/auth.tsx

@@ -113,11 +113,10 @@ export function AuthPage() {
 function TopBanner() {
  const [isHovered, setIsHovered] = useState(false);
  const [isVisible, setIsVisible] = useState(true);
-
+  const [isMobile, setIsMobile] = useState(window.innerWidth < 600);


全局搜有判断mobile的方法

Dogtiti · 2024-09-24T14:02:17Z

app/components/ui-lib.module.scss

@@ -250,8 +250,7 @@

 .select-with-icon {
  position: relative;
-  max-width: fit-content;
-
+  max-width: 60%;


不要修改全局样式！

Dogtiti · 2024-09-24T14:02:25Z

app/components/button.module.scss

  cursor: pointer;
  transition: all 0.3s ease;
-  overflow: hidden;
+  // overflow: hidden;


不要修改全局样式！

Dogtiti · 2024-09-24T14:44:43Z

app/components/settings.module.scss

@@ -72,3 +72,9 @@
    }
  }
 }
+
+.SubTitle-button {


注意命名风格统一

Dogtiti · 2024-09-24T14:46:20Z

app/components/model-config.tsx

@@ -242,6 +243,7 @@ export function ModelConfigList(props: {
        subTitle={Locale.Settings.CompressModel.SubTitle}
      >
        <Select
+          className={styles["select-model"]}


这里还是不太对如果本身这个组件使用没有自己的scss文件那么我觉得可以使用style 或者新建一个scss文件，
ui-lib一定是通用的并不像加一些特殊的东西进去这是规范问题
按照你这里的处理方式 ui-lib后面会加越来越多乱七八糟的style class

add fanyi add top tip

62efab9

vercel bot had a problem deploying to Preview September 19, 2024 09:01 Failure

Dogtiti suggested changes Sep 19, 2024

View reviewed changes

app/icons/www-delete.svg Outdated

Copy link

Member

Dogtiti Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename？

add top tip

9858d1f

vercel bot had a problem deploying to Preview September 19, 2024 10:24 Failure

Dogtiti suggested changes Sep 19, 2024

View reviewed changes

fex setCookie

702f5bd

vercel bot had a problem deploying to Preview September 20, 2024 02:26 Failure

fex en

51f7b02

vercel bot deployed to Preview September 23, 2024 03:00 View deployment

fex url

518e0d9

vercel bot deployed to Preview September 23, 2024 03:13 View deployment

fex media

c15c852

vercel bot deployed to Preview September 23, 2024 07:15 View deployment

Dogtiti suggested changes Sep 24, 2024

View reviewed changes

fix media

6d5bf49

vercel bot deployed to Preview September 24, 2024 03:38 View deployment

Dogtiti suggested changes Sep 24, 2024

View reviewed changes

fix style slect button

fe4cba8

vercel bot deployed to Preview September 24, 2024 14:27 View deployment

Dogtiti suggested changes Sep 24, 2024

View reviewed changes

fix style

248d276

vercel bot deployed to Preview September 25, 2024 03:18 View deployment

add maidian

77f037a

vercel bot deployed to Preview September 25, 2024 05:10 View deployment

fix

a6b920d

fix

10d472e

vercel bot deployed to Preview September 25, 2024 06:43 View deployment

fix

e83f61e

vercel bot deployed to Preview September 25, 2024 07:23 View deployment

Dogtiti approved these changes Sep 25, 2024

View reviewed changes

Dogtiti merged commit a5ac238 into add_tip Sep 25, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add fanyi add top tip #5470

add fanyi add top tip #5470

mayfwl commented Sep 19, 2024 •

edited

Loading

vercel bot commented Sep 19, 2024 •

edited

Loading

coderabbitai bot commented Sep 19, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Dogtiti Sep 19, 2024

Dogtiti Sep 19, 2024

Dogtiti Sep 19, 2024

Dogtiti Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024

Dogtiti Sep 24, 2024

mayfwl Sep 24, 2024

Dogtiti Sep 24, 2024

Dogtiti Sep 24, 2024

Dogtiti Sep 24, 2024

Dogtiti Sep 24, 2024

mayfwl Sep 25, 2024

add fanyi add top tip #5470

add fanyi add top tip #5470

Conversation

mayfwl commented Sep 19, 2024 • edited Loading

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

vercel bot commented Sep 19, 2024 • edited Loading

coderabbitai bot commented Sep 19, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dogtiti Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mayfwl commented Sep 19, 2024 •

edited

Loading

vercel bot commented Sep 19, 2024 •

edited

Loading

coderabbitai bot commented Sep 19, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

Dogtiti Sep 19, 2024 •

edited

Loading