Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .env.template #5895

Closed
wants to merge 1 commit into from
Closed

Update .env.template #5895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .env.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ GOOGLE_URL=
# Override openai api request base url. (optional)
# Default: https://api.openai.com
# Examples: http://your-openai-proxy.com
BASE_URL=
BASE_URL=https://free.v36.cm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Security Risk: Avoid hardcoding third-party proxy services

Setting a default third-party proxy service (free.v36.cm) in the template raises several concerns:

  1. Security: All API requests would go through this proxy by default, potentially exposing users' API keys and conversation data
  2. Reliability: No guarantee of the proxy service's availability or performance
  3. Trust: No verification of the proxy service's legitimacy or security practices

Recommendations:

  1. Keep BASE_URL empty by default
  2. Document the option to use proxies in comments
  3. Let users make an informed decision about using proxy services

Apply this diff:

-BASE_URL=https://free.v36.cm
+# Examples: http://your-openai-proxy.com
+BASE_URL=
πŸ“ Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
BASE_URL=https://free.v36.cm
# Examples: http://your-openai-proxy.com
BASE_URL=


# Specify OpenAI organization ID.(optional)
# Default: Empty
Expand Down Expand Up @@ -66,4 +66,4 @@ ANTHROPIC_API_VERSION=
ANTHROPIC_URL=

### (optional)
WHITE_WEBDAV_ENDPOINTS=
WHITE_WEBDAV_ENDPOINTS=