feat: Search improvement #5874
Closed
feat: Search improvement #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
apa420
force-pushed
the
search-improvement
branch
from
21b60e3 to
6386cc8
Compare
Nerixyz
reviewed
Feb 1, 2025
pajlada
reviewed
Feb 2, 2025
There was a problem hiding this comment.
Not a full review
I like the Hotkeys "Search keybind" functionality
I like that I can CTRL+F to find a hotkey name
I don't like that I can CTRL+F to find the hotkey keybinding
I don't like it searching through accounts/nicknames/highlights/ignoresfilters/logs
I'm torn on searching through commands with this
|
Closed in favor of #5884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the functionality of searching for fields on the tables we have in the settings pages. You can for example search for the name you gave a hotkey and it'll show up. Or you can search for "whisper" and find that you have a highlight for it in the highlights tab!
Partially fixes #5872