Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip of policy evaluated when the scan not finished(AST-81796) #1033

Merged
merged 4 commits into from
Feb 9, 2025

Conversation

sarahCx
Copy link
Contributor

@sarahCx sarahCx commented Feb 4, 2025

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

When try to getting the policy management step, the user receive a message indicating that the scan is currently running and policy management step is being skipped.

References

https://checkmarx.atlassian.net/browse/AST-81796

Testing

Add integration test that try to show results before the scan finished.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

internal/commands/result.go Show resolved Hide resolved
test/integration/scan_test.go Show resolved Hide resolved
Copy link

github-actions bot commented Feb 4, 2025

Logo
Checkmarx One – Scan Summary & Details35ef432c-902b-49b4-9b19-5e96666b7c37

Great job, no security vulnerabilities found in this Pull Request

@sarahCx sarahCx merged commit 69a3b47 into main Feb 9, 2025
9 of 10 checks passed
@sarahCx sarahCx deleted the feature/saraChen/notEvaluatePolicy branch February 9, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants