Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test branch #983

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

test branch #983

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9c8ceb0
test branch
Korjen97 Dec 24, 2024
29d183f
Merge branch 'main' into Korjen97-patch-3
AlvoBen Jan 23, 2025
ca8146e
Update ci.yml
AlvoBen Jan 23, 2025
8bcd5e0
Update scan.go
AlvoBen Jan 23, 2025
fb4f063
Update scan.go
AlvoBen Jan 23, 2025
8fc8e6a
Update ci.yml
AlvoBen Jan 23, 2025
2452fa6
Update ci.yml
AlvoBen Jan 23, 2025
914f4ef
Update ci.yml
AlvoBen Jan 23, 2025
79d279c
Update ci.yml
AlvoBen Jan 23, 2025
29161db
fix
BenAlvo1 Jan 23, 2025
51b3634
fix
BenAlvo1 Jan 23, 2025
27da0fb
fix
BenAlvo1 Jan 23, 2025
7197057
fix
BenAlvo1 Jan 23, 2025
08a0ad4
fix
BenAlvo1 Jan 23, 2025
d7b1fc1
fix1
BenAlvo1 Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,17 @@ jobs:
with:
go-version-file: go.mod
- run: go version

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the original docker version command was removed without replacement. If the intention is to verify the Docker installation, consider adding a step to check the Docker version or ensure Docker is properly set up.

- name: Setup Docker on macOS
uses: docker/setup-buildx-action@v1

- name: Login to Docker Hub
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Login to Docker Hub step appears to be redundant since you've already added a Log in to Docker Hub step above. Consider removing this duplicate step to streamline the workflow.

uses: docker/login-action@dd4fa0671be5250ee6f50aedf4cb05514abda2c7 #v1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a commit SHA (dd4fa0671be5250ee6f50aedf4cb05514abda2c7) directly for the docker/login-action is not recommended for maintainability. Prefer using a version tag (like v1) unless there is a specific reason for pinning to a commit.

with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
- name: go test with coverage
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shell: bash directive is unnecessary here as bash is the default shell for GitHub Actions runners on Linux and macOS. You can remove this line unless there's a specific need for it.

shell: bash
run: |
sudo chmod +x ./internal/commands/.scripts/up.sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using sudo within the GitHub Actions runner should generally be avoided unless necessary. Check if the chmod command can be run without sudo.

./internal/commands/.scripts/up.sh
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

</div>

<!-- PROJECT LOGO -->
<!-- PROJECT LOGO -->
<br />
<p align="center">
<a href="">
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/checkmarx/ast-cli

go 1.23.3
go 1.23.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go version is updated from 1.23.3 to 1.23.5. Please ensure that this minor version bump does not introduce any compatibility issues with the project dependencies and that all tests pass with the new version.


require (
github.com/Checkmarx/containers-resolver v1.0.4
Expand Down
2 changes: 1 addition & 1 deletion internal/commands/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const (
containerVolumeFlag = "-v"
containerNameFlag = "--name"
containerRemove = "--rm"
containerImage = "checkmarx/kics:latest"
containerImage = "checkmarx/kics:v2.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The container image tag has been changed to include a v prefix. Ensure that the tag v2.1.3 exists in the container registry and is the correct version intended for use. If this is a new tagging convention, update any documentation or scripts that reference the old tag format to prevent confusion.

containerScan = "scan"
containerScanPathFlag = "-p"
containerScanPath = "/path"
Expand Down
Loading