Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): openapi maximum_length_undefined query enum and format sanitizers #7327

Merged
merged 4 commits into from
Feb 3, 2025
Merged

fix(query): openapi maximum_length_undefined query enum and format sanitizers #7327

merged 4 commits into from
Feb 3, 2025

Conversation

EduardoSemanas
Copy link
Contributor

@EduardoSemanas EduardoSemanas commented Feb 3, 2025 •
edited
Loading

Reason for Proposed Changes

  • Enum and Format (when set to 'date' or 'date-time') should be recognized as sanitizers

Proposed Changes

  • OpenAPI general query maximum_length_undefined updated to consider format (date and date-time) and enum as sanitizers
  • Query negative UTs added

I submit this contribution under the Apache-2.0 license.

@EduardoSemanas EduardoSemanas requested a review from a team as a code owner February 3, 2025 11:53
@github-actions github-actions bot added query New query feature openapi OpenAPI query labels Feb 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

kics-logo

KICS version: v2.1.4

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

ArturRibeiro-CX
ArturRibeiro-CX previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean changes and nice addition of test cases!
Great example here as well: https://swagger.io/specification/#:~:text=%22enum%22%3A%20%5B%22clueless%22%2C%20%22lazy%22%2C%20%22adventurous%22%2C%20%22aggressive%22%5D

ArturRibeiro-CX
ArturRibeiro-CX approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduardoSemanas EduardoSemanas merged commit 2e3a47b into master Feb 3, 2025
27 checks passed
@EduardoSemanas EduardoSemanas deleted the eduardose/maximum_length_undefined branch February 3, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@ArturRibeiro-CX ArturRibeiro-CX ArturRibeiro-CX approved these changes

Assignees

@EduardoSemanas EduardoSemanas

Labels
openapi OpenAPI query query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EduardoSemanas @cxMiguelSilva @ArturRibeiro-CX