-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration and updates #260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lpetrora
commented
Sep 5, 2024
- Switched from yarn to npm
- Updated dependencies to latest version
- Updated code to be compatible with latest dependencies versions
- Updated unit tests
- Migrated Cypress e2e tests to Playwright
- e2e tests run dockerized. It spawns 3 containers: Grafana, Checkmk, and Playwright
- Updated Github actions in order to run the Playwright e2e tests on github actions
* Switched from yarn to npm * Updated dependencies to latest version * Updated code to be compatible with latest dependencies versions * Updated unit tests
* Migrated Cypress e2e tests to Playwright
The e2e tests now run inside docker. It spawns 3 containers: * Grafana * Checkmk * Playwright runner In order to run the tests, first you need to manually build the plugin > npm run build With the plugin built, the tests run unattended from docker tests > docker compose up --build
* Prettified files
lpetrora
force-pushed
the
lp-master-datasource-migration
branch
3 times, most recently
from
September 6, 2024 14:41
14a37d7
to
72f5728
Compare
* Update github actions
lpetrora
force-pushed
the
lp-master-datasource-migration
branch
from
September 6, 2024 14:43
72f5728
to
d18089c
Compare
BenediktSeidl
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor details. but also happy to merge it as is!
tests/checkmk-docker-hooks/post-start/generate_random_rrd_data.py
Outdated
Show resolved
Hide resolved
lpetrora
force-pushed
the
lp-master-datasource-migration
branch
5 times, most recently
from
September 9, 2024 08:12
0ba0121
to
32a2099
Compare
* Updated DEVELOPMENT.md * Fixed typos and whitespaces * Added missing prettier-plugin-sort-imports plugin
lpetrora
force-pushed
the
lp-master-datasource-migration
branch
from
September 9, 2024 08:37
32a2099
to
df1d2d5
Compare
BenediktSeidl
approved these changes
Sep 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.