Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration and updates #260

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Migration and updates #260

merged 6 commits into from
Sep 9, 2024

Conversation

lpetrora
Copy link
Member

@lpetrora lpetrora commented Sep 5, 2024

  • Switched from yarn to npm
  • Updated dependencies to latest version
  • Updated code to be compatible with latest dependencies versions
  • Updated unit tests
  • Migrated Cypress e2e tests to Playwright
  • e2e tests run dockerized. It spawns 3 containers: Grafana, Checkmk, and Playwright
  • Updated Github actions in order to run the Playwright e2e tests on github actions

* Switched from yarn to npm
* Updated dependencies to latest version
* Updated code to be compatible with latest dependencies versions
* Updated unit tests
* Migrated Cypress e2e tests to Playwright
The e2e tests now run inside docker. It spawns 3 containers:
* Grafana
* Checkmk
* Playwright runner

In order to run the tests, first you need to manually build the plugin

> npm run build

With the plugin built, the tests run unattended from docker

tests > docker compose up --build
* Prettified files
@lpetrora lpetrora force-pushed the lp-master-datasource-migration branch 3 times, most recently from 14a37d7 to 72f5728 Compare September 6, 2024 14:41
* Update github actions
@lpetrora lpetrora force-pushed the lp-master-datasource-migration branch from 72f5728 to d18089c Compare September 6, 2024 14:43
Copy link
Contributor

@BenediktSeidl BenediktSeidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor details. but also happy to merge it as is!

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
tests/e2e/config.ts Outdated Show resolved Hide resolved
@lpetrora lpetrora force-pushed the lp-master-datasource-migration branch 5 times, most recently from 0ba0121 to 32a2099 Compare September 9, 2024 08:12
* Updated DEVELOPMENT.md
* Fixed typos and whitespaces
* Added missing prettier-plugin-sort-imports plugin
@lpetrora lpetrora force-pushed the lp-master-datasource-migration branch from 32a2099 to df1d2d5 Compare September 9, 2024 08:37
@lpetrora lpetrora merged commit 9b8ef2a into main Sep 9, 2024
5 checks passed
@lpetrora lpetrora deleted the lp-master-datasource-migration branch September 9, 2024 09:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants