CHIA-1248 Adapt to fixing get_conditions_from_spendbundle's return value to include the cost of the whole spend #18537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
Changed
AmineKhaldi
force-pushed
the
adapt_to_cost_calculation_fix
branch
from
86f493a to
d1afde2
Compare
AmineKhaldi
force-pushed
the
threadpoolexecutor
branch
from
19f6cd6 to
7835275
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
merge_conflict
AmineKhaldi
force-pushed
the
adapt_to_cost_calculation_fix
branch
from
d1afde2 to
4bf7a21
Compare
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
AmineKhaldi
force-pushed
the
threadpoolexecutor
branch
from
7835275 to
fb71e79
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
merge_conflict
AmineKhaldi
force-pushed
the
adapt_to_cost_calculation_fix
branch
from
4bf7a21 to
0d66536
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
merge_conflict
|
are you changing these numbers back to where they are in main? |
AmineKhaldi
force-pushed
the
threadpoolexecutor
branch
from
fb71e79 to
c53d78b
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
merge_conflict
AmineKhaldi
force-pushed
the
adapt_to_cost_calculation_fix
branch
from
0d66536 to
3e35acc
Compare
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
…lude the cost of the whole spend.
AmineKhaldi
force-pushed
the
adapt_to_cost_calculation_fix
branch
from
3e35acc to
d8063a1
Compare
|
Superseded by PR #18557. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This adapts this effort to Chia-Network/chia_rs#680 which fixes the fundamental issue that caused us to alter some test values.
Current Behavior:
We needed to alter some test values to get some tests to pass beyond a slight decrease in costs.
New Behavior:
The code works as it should and we only need to account for the slight cost decrease when needed.