Fixed an issue where cancelling NFT offer did not cancel other offers…

[ChiaMineJP]

Fixing Chia-Network/chia-blockchain-gui#2563

I found that the primary issues of the above case are:

1. Canceling an offer with a NFT in offering-side does not set PENDING_CANCEL status for trades which also offers the same NFT.

• This is because current wallet implementation updates trade status by trade_id and not by coins being spent.

2. Confirming cancellation does not set CANCELLED status to the trade records.

• I understood the root cause. I'll desribe it in the following paragraph.

Why cancelling multiple NFT offers doesn't work

When confirming the offer cancellation, which means the offering NFT coin was spent but requesting coins were not created, trade_records wallet db table in the issue's situation would be like:

trade_id	status
offer1	PENDING_ACCEPT
offer2	PENDING_ACCEPT
offer3	PENDING_CANCEL

(This inconsistent statuses is caused by issue 1. above.)

Then look at the code below. This code is executed when monitoring coin state has been changed.
For example, the offering coin is spent to cancel.
https://github.com/Chia-Network/chia-blockchain/blob/2.5.0/chia/wallet/trade_manager.py#L154

The target trade whose status is expected to be set to CANCELLED is acquired by self.get_trade_by_coin(coin_state.coin).
This is the problem.
When this is executed, it gets offer1 in the above table.
offer1's status is PENDING_ACCEPT.
When offer is cancelled, its status must be PENDING_CANCEL according to
https://github.com/Chia-Network/chia-blockchain/blob/2.5.0/chia/wallet/trade_manager.py#L204

So the current implementation misses to recognize offer cancellation for NFT.
This is the PR to fix this issue.

[Quexington]

Just as a note, this is techincally a hack to cover up the fact that we're allowing users to create more than one offer of the same coin.

[Rigidity]

Just as a note, this is techincally a hack to cover up the fact that we're allowing users to create more than one offer of the same coin.

It's desirable to allow this, if you want to request multiple different assets as options.

[github-actions]

File	Coverage	Missing Lines
chia/wallet/trade_manager.py	93.6%	lines 158-159, 161

Total	Missing	Coverage
53 lines	3 lines	94%

[Quexington]

Just as a note, this is techincally a hack to cover up the fact that we're allowing users to create more than one offer of the same coin.

It's desirable to allow this, if you want to request multiple different assets as options.

Well that's a hack too for not supporting this functionality natively