Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update windows source install #631

Merged
merged 1 commit into from
Jul 30, 2024
Merged

update windows source install #631

merged 1 commit into from
Jul 30, 2024

Conversation

BrandtH22
Copy link
Collaborator

  • ensure removal all virtual environments are noted in update instructions

@BrandtH22
update windows source install
ac146ea 
- ensure removal all virtual environments are noted in update instructions
hoffmang9
hoffmang9 reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows source install but rm isn't windows valid?

@BrandtH22
Copy link
Collaborator Author

windows source install but rm isn't windows valid?

rm is valid in powershell and since we provide the ps1 file for installation I have personally always recommended users use powershell over cmd (plus powershell has been the default shell for windows for ~8 years).

(chia-blockchain-py3.12) PS C:\Users\USERNAME\chia-blockchain> deactivate
PS C:\Users\USERNAME\chia-blockchain> rm -r venv
PS C:\Users\USERNAME\chia-blockchain> rm -r .penv
PS C:\Users\USERNAME\chia-blockchain> rm -r .venv
PS C:\Users\USERNAME\chia-blockchain> ./Install.ps1

works as expected

hoffmang9
hoffmang9 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stand corrected.

@BrandtH22 BrandtH22 merged commit cf721be into main Jul 30, 2024
8 checks passed
@BrandtH22 BrandtH22 deleted the update-install-instructions branch July 30, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmang9 hoffmang9 hoffmang9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrandtH22 @hoffmang9