My comments #75
Draft
My comments #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, will read. |
| @@ -1,3 +1,7 @@ | |||
| ### ?? What is this? I couldn't find any references to this file so I can't tell | |||
| if it's documentation or notes or ??? | |||
There was a problem hiding this comment.
it's a https://lamport.azurewebsites.net/tla/tla.html tla+ model of potato handler. i wasn't sure that the protocol it spoke couldn't be stalled, so made a model of it, fixed the stalls and then changed potato handler to be like it. I introduced it in this pr: #64
I want to do more modelling and more to ensure that things are ok, but time has been tight.
| @@ -0,0 +1,9 @@ | |||
| One very likely user of this code will be third parties who want to implement games. To make this code as reusable as possible for these users, separate game-specific code from generic refereee etc. code. Maybe something like: | |||
|
|
|||
There was a problem hiding this comment.
ya, we should finally move calpoker into its own directory and isolate each.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.