Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wheel to workspace #394

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Add wheel to workspace #394

merged 6 commits into from
Feb 7, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Feb 6, 2024

The wheel is currently excluded from the workspace, which causes headaches for various parts of the workflow. This adds it to the workspace. In doing so, it causes linker errors when running the tests with the extension-module feature. As such, this feature has been removed from the wheel/Cargo.toml and added to pyproject.toml for Maturin only.

@Rigidity Rigidity requested a review from arvidn February 6, 2024 20:01
Copy link

coveralls-official bot commented Feb 6, 2024

Pull Request Test Coverage Report for Build 7806527751

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 84.787%

Files with Coverage Reduction New Missed Lines %
src/gen/run_block_generator.rs 1 96.43%
Totals Coverage Status
Change from base Build 7804182997: 0.08%
Covered Lines: 11247
Relevant Lines: 13265

💛 - Coveralls

@Rigidity Rigidity merged commit 4b0ac5b into main Feb 7, 2024
63 checks passed
@Rigidity Rigidity deleted the wheel-ws branch February 7, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants