Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tests into a test module in get_puzzle_and_solution_for_coin.rs #642

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 5, 2024

this is best reviewed with whitespaces ignored.
https://github.com/Chia-Network/chia_rs/pull/642/files?diff=split&w=1

@arvidn arvidn requested a review from Rigidity August 5, 2024 15:57
@arvidn arvidn marked this pull request as ready for review August 5, 2024 16:19
Copy link

Pull Request Test Coverage Report for Build 10252082124

Details

  • 121 of 123 (98.37%) changed or added relevant lines in 1 file are covered.
  • 563 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-1.8%) to 78.946%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/gen/get_puzzle_and_solution.rs 121 123 98.37%
Files with Coverage Reduction New Missed Lines %
crates/chia-consensus/src/gen/run_puzzle.rs 1 98.31%
crates/chia-traits/src/streamable.rs 1 94.03%
crates/chia-consensus/src/gen/run_block_generator.rs 2 95.42%
crates/chia-consensus/src/gen/validation_error.rs 4 24.19%
crates/chia-consensus/src/gen/conditions.rs 5 99.26%
crates/chia-protocol/src/lazy_node.rs 9 64.0%
wheel/src/run_program.rs 11 68.57%
crates/chia-protocol/src/spend_bundle.rs 13 75.97%
crates/chia-traits/src/to_json_dict.rs 24 11.11%
crates/chia-traits/src/from_json_dict.rs 27 8.33%
Totals Coverage Status
Change from base Build 10249879023: -1.8%
Covered Lines: 11114
Relevant Lines: 14078

💛 - Coveralls

@arvidn arvidn merged commit 5c68492 into main Aug 6, 2024
57 checks passed
@arvidn arvidn deleted the tests-mod-puzzle-solution branch August 6, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants