Fix clippy warning and deny them in the future #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12297656321Details
💛 - Coveralls |
altendky
approved these changes
Dec 12, 2024
arvidn
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back I loosened the CI a bit to allow warnings through, and differentiated some of the warnings as hard errors. I think this is great for during development so you aren't forced to fix every strict clippy warning immediately, but when you're merging a PR through I think all of the warnings should be fixed beforehand. So I re-added the check in CI to deny warnings, while leaving it alone in precommit.
Another reason for allowing them before was that new nightly Rust versions would break CI without us changing the code. Now that we both use stable, and use a rust-toolchain.toml file, this is theoretically impossible.