-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chia-blockchain dependency for most of chia_rs #887
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a really nice change. However, I think it would be good to check the correctness of this against the existing python implementation. One way to do that would be to break this off into a separate PR that still relies on the chia-blockchain
dependency to compare the result between the rust and python implementation. Can you think of another way to be confident in the correctness of this port?
Pull Request Test Coverage Report for Build 12832667348Details
💛 - Coveralls |
@@ -4,7 +4,9 @@ | |||
pub const UI_ACTUAL_SPACE_CONSTANT_FACTOR: f32 = 0.78; | |||
|
|||
// TODO: Update this when new plot format releases | |||
pub fn expected_plot_size(k: u32) -> u64 { | |||
#[cfg(feature = "py-bindings")] | |||
#[pyo3::pyfunction] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have to do #[cfg_attr(feature = "py-bindings", pyo3::pyfunction)]
instead?
This PR removes imports from
test_blscache.py
and deletestest_program_fidelity.py
.It also removes the python running from
block_record.rs
by implementingpot_iterations.py
inside the class