Skip to content

Commit

Permalink
Release Candidate 1 for 1.7.2 (#138)
Browse files Browse the repository at this point in the history
* Added unit tests for issue #118

* Add unit test for #120

* Bug fix - fixes #120

* Update version number

* Fixes #124 (#125)

* Added testing for issue #121 -- will fail

* Changed to camel case to accomodate future variable renaming

* Added handling of ISO 8601 timestamps without fractional seconds. See issue #121

* Increased minimum version of R because of `anyNA` function.

* Unformatted dates kept as chr; added warning; added tests

* Added tests for #124 -- will fail

* Handles downloadURL from ls.socrata. Fixes #124

* Closes #129

* Iteration version

* startsWith() requires R >= 3.3.0

* Resolves #133. Also documents per #132

* Updated to reflect consequence of #133

* resolved merge conflict from rebasing

* fixing test - dataset is live so rows can increase, and fixed data types.

* add unit test for issue #118 - will fail

* fixes #118

* Add .gitattributes, ignores it during R build. Closes #135

* Fixes #134

* Clarified language on installing from GitHub

* Removed penultimate release from build testing. Closes #136

* Updated formatting for sections

* Update NEWS.md for 1.7.2 release.

* Included remaining changes to NEWS
  • Loading branch information
nicklucius authored Apr 12, 2017
1 parent dfa7001 commit eae61b5
Show file tree
Hide file tree
Showing 9 changed files with 564 additions and 482 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
\.gitignore
\.gitattributes
\.project
\.settings
\.Rbuildignore
Expand Down
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Declare R files to use CRLF line endings
*.R text col=crlf
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ sudo: false
language: r
cache: packages
r:
- oldrel
- release
- devel

Expand All @@ -29,4 +28,4 @@ notifications:
- https://webhooks.gitter.im/e/104bab7ef95b3a1bfd4c
on_success: always # options: [always|never|change] default: always
on_failure: always # options: [always|never|change] default: always
on_start: never # options: [always|never|change] default: always
on_start: never # options: [always|never|change] default: always
11 changes: 7 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@ If you have multiple issues, please submit multiple requests. Once you submit yo
When you want to make a change, either to fix a bug or introduce a new feature, please follow the instructions below

* Create a branch or fork of the project based off of the `dev` branch.
* Make commits of logical units
* Add unit tests for any new features
* Make commits of logical units.
* Add unit tests for any new features.
* Document any new functions or new arguments within any existing function.
* Iterate either version or build number in the `DESCRIPTION` file:
* The version number follows the `x.y.z-build` format and increments based on [semantic versioning 2.0.0](http://semver.org/spec/v2.0.0.html). Please update versions corresponding to those guidelines.
* If your contribution takes several commits, please increment the build number (e.g., x.y.z-build) so there is a unique relationship of the version-build number to each commit.
* Run all tests in `tests/testthat/`
* Create a pull request with a robust description or [reference the issue number](https://github.com/Chicago/RSocrata/issues)
* Update the DESCRIPTION file for any new dependencies on packages or minimum verson of R required (up to the current release of R).
* Run all tests in `tests/testthat/`.
* Create a pull request with a robust description or [reference the issue number](https://github.com/Chicago/RSocrata/issues) to the `dev` branch (read the package's [formal git-flow policy](https://github.com/Chicago/RSocrata/wiki/Git-Flow)).

8 changes: 4 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ Description: Provides easier interaction with
format and manages throttling by 'Socrata'.
Users can upload data to Socrata portals directly
from R.
Version: 1.7.2-5
Date: 2017-02-23
Version: 1.7.2-12
Date: 2017-03-16
Author: Hugh Devlin, Ph. D., Tom Schenk, Jr., and John Malc
Maintainer: "Tom Schenk Jr." <[email protected]>
Depends:
R (>= 3.1.0)
R (>= 3.3.0)
Imports:
httr (>= 1.0.0),
jsonlite (>= 0.9.16),
Expand All @@ -28,4 +28,4 @@ Suggests:
License: MIT + file LICENSE
URL: https://github.com/Chicago/RSocrata
BugReports: https://github.com/Chicago/RSocrata/issues
RoxygenNote: 5.0.1
RoxygenNote: 6.0.1
18 changes: 18 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,21 @@ Bug fixes:
* Fixes a bug where the POSIX date conversion would not occur when using the JSON SoDA url (#85)
* Queries now follow SoDA guidelines and are explicitly sorted. This could have caused a silent error where some row may not have downloaded. ([#15](https://github.com/Chicago/RSocrata/issues/15))

### 1.7.2 Several changes:

Performance improvements:

* By default, 1000 rows at a time were being retreived for each API call while paging through data. Increased to retreive 50,000 rows for each API call. ([#129](https://github.com/Chicago/RSocrata/issues/129))

Bug fixes:

* Fixed a bug which caused an error if a ```select=count()``` statement was present in a URL. ([#120](https://github.com/Chicago/RSocrata/issues/120))
* Fixed a bug when data types are not found because there are no ```X-SODA2-*``` headers available in the API response. Users will now get a warning and data will be returned as ```character```. ([#118](https://github.com/Chicago/RSocrata/issues/118))
* Fixed a bug which did not recognize URLs listed from ```ls.socrata()``` as valid URLs to be used in ```read.socrata()```. Users will now be able to use URLs from the former function in the latter function. ([#124](https://github.com/Chicago/RSocrata/issues/124))
* Removed unit tests for older releases of R. ([#136](https://github.com/Chicago/RSocrata/issues/136))

Deprecation:

RSocrata's core development team has stated a formal policy to only support the most recent release of R. Until now, RSocrata was tested against the penultimate release of R; however, testing will be limited to the current version of R and the current development release. The project's [contributing guidelines](https://github.com/Chicago/RSocrata/blob/master/CONTRIBUTING.md) have been updated to reflect that accepted changes to RSocrata must pass tests on the current and penulimate versions of R.

While RSocrata is only tested on the current and penultimate version, the core development team expects it will work on older versions most of the time. See [#132](https://github.com/Chicago/RSocrata/issues/132) for more information.
Loading

0 comments on commit eae61b5

Please sign in to comment.