BugFixed: crazyxiaoj #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that appear in the GitHub issue 1. a wrong conversion of a string in the '__reformSequence' function. 2. a missing 'occupied' check for ORFs where no stop codon was found. 3. a fuzzy 'end' representation for ORFs where no stop codon was found. Other fixes that do not appear in the GitHub issue 1. a wrong nested decision for ORFs that have different senses. 2. a different definition of the "start/end" key for ORFs that have different senses. 3. noncontinuous indexs for the ORFs because the assignment occurs before the nesting.
|
I noticed that the pull request hasn't been merged yet. Is there any issue or confusion? If so, please let me know so I can address it. |
|
Hello, I believe these changes are crucial for the normal operation of the program. Numerous unit tests have shown that they improve the accuracy and clarity of the returned results. If you wish to modify my submission, please merge this pull request and submit the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that appear in the GitHub issue
Other fixes that do not appear in the GitHub issue
Other changes: some comments have been added to the code to enhance maintainability