Fixing deadlock in AnalogEQPlot destructor (#43)

* Fixing deadlock in AnalogEQPlot destructor * Apply clang-format * Fixing include dir --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Chowdhury-DSP · Jun 17, 2024 · 2d77bdc · 2d77bdc
1 parent 3d81f13
commit 2d77bdc
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/modules/CMakeLists.txt b/modules/CMakeLists.txt
@@ -1,7 +1,6 @@
 add_subdirectory(JUCE)
 add_subdirectory(chowdsp_utils)
 add_subdirectory(chowdsp_wdf)
-add_subdirectory(eigen)
 add_subdirectory(LBFGSpp)
 
 subproject_version(JUCE juce_version)
@@ -28,7 +27,6 @@ target_link_libraries(juce_plugin_modules
         chowdsp::chowdsp_wdf
         chowdsp::chowdsp_gui
         chowdsp::chowdsp_visualizers
-        Eigen3::Eigen
         lbfgspp
     PUBLIC
         juce::juce_recommended_config_flags
@@ -73,6 +71,7 @@ target_compile_definitions(juce_plugin_modules
 target_include_directories(juce_plugin_modules
     PUBLIC
         ${CMAKE_CURRENT_SOURCE_DIR}/exprtk
+        ${CMAKE_CURRENT_SOURCE_DIR}/eigen
     INTERFACE
         $<TARGET_PROPERTY:juce_plugin_modules,INCLUDE_DIRECTORIES>
 )

diff --git a/modules/LBFGSpp/CMakeLists.txt b/modules/LBFGSpp/CMakeLists.txt
@@ -38,7 +38,7 @@ target_include_directories(lbfgspp INTERFACE
 # | FIND EXTERNAL LIBRARIES |
 # + ----------------------- +
 
-target_link_libraries(lbfgspp INTERFACE Eigen3::Eigen)
+#target_link_libraries(lbfgspp INTERFACE Eigen3::Eigen)
 
 # + ------------ +
 # | INSTALLATION |

diff --git a/src/gui/AnalogEQ/AnalogEQPlot.cpp b/src/gui/AnalogEQ/AnalogEQPlot.cpp
@@ -79,8 +79,12 @@ int AnalogEQPlot::BackgroundPlotter::useTimeSlice()
     {
         filterPlotter.updateFilterPlot();
 
-        juce::MessageManagerLock mml {};
-        parent.repaint();
+        juce::MessageManager::callAsync (
+            [safeParent = juce::Component::SafePointer { &parent }]
+            {
+                if (safeParent != nullptr)
+                    safeParent->repaint();
+            });
     }
 
     return 30;