Bugfix write newline #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
First of all thanks for making this port to arduino! I'm using in my project that is based on avr now.
I had a problem that when I was printing new line with addch, and when I was trying to delete the previous character with delch, I had problem trying to move back to a relative position like x = x - 1. And I found out the problem that the cursor y and x was not being updated properly. (I'm making a CLI/Shell in my project)
All the functions like getnstr and editLine they just avoid the KEY_CR so I think it was not being printed at all in previous projects. And I also tried my changes with some of the examples and they seem to work just fine.
So, if you want, you can add this change to the library. Any questions / further testing just ping me
Thanks!