cleanup env vars (#209)

src/Runner.Client/Program.cs

@@ -496,6 +496,8 @@ private static async Task<int> CreateExternalRunner(string binpath, Parameters p
                         var code = await inv.ExecuteAsync(tmpdir, file, arguments, runnerEnv, true, null, true, CancellationTokenSource.CreateLinkedTokenSource(source.Token, new CancellationTokenSource(60 * 1000).Token).Token);
                         int execAttempt = 1;
                         var success = false;
+                        // unset RUNNER_SERVER_CONFIG_ROOT to not appear in jobs created by external runners
+                        runnerEnv.Remove("RUNNER_SERVER_CONFIG_ROOT");
                         while(true) {
                             file = runner;
                             try {

src/Runner.Common/HostContext.cs

@@ -66,6 +66,7 @@ public sealed class HostContext : EventListener, IObserver<DiagnosticListener>,
         private StartupType _startupType;
         private string _perfFile;
         private RunnerWebProxy _webProxy = new RunnerWebProxy();
+        private string configRoot = null;
 
         public event EventHandler Unloading;
         public CancellationToken RunnerShutdownToken => _runnerShutdownTokenSource.Token;
@@ -78,6 +79,8 @@ public HostContext(string hostType, string logFile = null)
             // Validate args.
             ArgUtil.NotNullOrEmpty(hostType, nameof(hostType));
 
+            configRoot = Environment.GetEnvironmentVariable("RUNNER_SERVER_CONFIG_ROOT");
+
             _loadContext = AssemblyLoadContext.GetLoadContext(typeof(HostContext).GetTypeInfo().Assembly);
             _loadContext.Unloading += LoadContext_Unloading;
 
@@ -265,7 +268,7 @@ public string GetDirectory(WellKnownDirectory directory)
                     break;
 
                 case WellKnownDirectory.ConfigRoot:
-                    path = Environment.GetEnvironmentVariable("RUNNER_SERVER_CONFIG_ROOT") ?? GetDirectory(WellKnownDirectory.Root);
+                    path = configRoot ?? GetDirectory(WellKnownDirectory.Root);
                     break;
 
                 case WellKnownDirectory.Temp:

src/Runner.Listener/Program.cs

@@ -24,6 +24,9 @@ public static int Main(string[] args)
                     Console.WriteLine($"Failed to change Process Group exception");
                 }
             }
+            // Delete the environment variable, otherwise it is defined inside the job
+            System.Environment.SetEnvironmentVariable("GHARUN_CHANGE_PROCESS_GROUP", null);
+
             // Add environment variables from .env file
             LoadAndSetEnv();
 

src/Runner.Server/Program.cs

@@ -27,9 +27,8 @@ public static void Main(string[] args)
                     Console.WriteLine($"Failed to change Process Group exception");
                 }
             }
-            //var b = new ConfigurationBuilder();
-            //b.AddJsonFile("C:\\Users\\Christopher\\runner\\src\\Runner.Server\\appsettings.Development.json");
-            //new MessageController(/* new Logger<MessageController>(new LoggerFactory()) */b.Build(), new MemoryCache(new Options())).ConvertYaml("C:/Users/Christopher/runner/src/Runner.Server/test.yml");
+            // Delete the environment variable, otherwise it is defined inside the job
+            System.Environment.SetEnvironmentVariable("GHARUN_CHANGE_PROCESS_GROUP", null);
             CreateHostBuilder(args).Build().Run();
         }
 

src/Runner.Worker/Program.cs

@@ -13,6 +13,8 @@ public static int Main(string[] args)
         {
             using (HostContext context = new HostContext("Worker"))
             {
+                // Delete the environment variable, otherwise it is defined inside the job
+                Environment.SetEnvironmentVariable("RUNNER_SERVER_CONFIG_ROOT", null);
                 return MainAsync(context, args).GetAwaiter().GetResult();
             }
         }