Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve installation script and various small fixes #161

Merged
merged 24 commits into from
Apr 24, 2024
Merged

Improve installation script and various small fixes #161

merged 24 commits into from
Apr 24, 2024

Conversation

gartens
Copy link
Contributor

@gartens gartens commented Nov 21, 2023 •
edited
Loading

Improvements to the installer:

  • Drop unused variable $output.
  • Add a wrapper around the clone calls and display stderr on error.
  • Pass the desired revision directly to the clone command instead of executing a second command.
  • Get rid of superfluous single quotes and add them where required.
  • HTML escape error messages.
  • Keep already entered form values when the installation fails except for passwords.
  • Remove option to clone repository via Mercurial. Only Git is supported now.
  • Update README.md
  • Disable FTP upload for local clients by default
  • When successful, redirect the user to index.php

Improvements to Chronos:

  • Use the O_EXCL flag for opening lock files
  • Factor multiple instances of file_exists and file_get_contents into a helper
  • Replace a PNG with a SVG
  • Make the .htaccess files stricter
  • Display a 404 page when non-existent controllers/actions are accessed
  • Fix various warnings and typos

@gartens gartens changed the title Improve installation script Improve installation script and various small fixes to Chronos Dec 6, 2023
@vogti vogti changed the title Improve installation script and various small fixes to Chronos Improve installation script and various small fixes Dec 10, 2023
gartens and others added 24 commits April 24, 2024 13:19
@gartens @vogti
Improve installation script
9d1cc2e 
 - Drop unused variable $output.
 - Add a wrapper around the clone calls and display stderr on error.
 - Pass the desired revision directly to the clone command instead of
   executing a second command.
 - Get rid of superfluous single quotes and add them where required.
 - HTML escape error messages.
 - Keep already entered form values when the installation fails except
   for passwords.
@gartens @vogti
Remove mercurial option from installer
1431549
@gartens @vogti
Disable FTP upload for local clients by default
2468f7c
@gartens @vogti
Avoid passing null to method_exists
2a518b1
@gartens @vogti
Avoid warnings about implicit conversions from float to integer
19d793a
@gartens @vogti
Display a 404 page for non-existent controllers/actions
0a08735
@gartens @vogti
Replace blurry "plus" PNG with a crisp SVG
22976ae
@gartens @vogti
Replace multiple instances of file_exists + file_get_contents with he…
d6c715a 
…lper
@gartens @vogti
Use correct variable in exception message
8ae13d0
@gartens @vogti
Exit early when the class name does conform to our expectations
ae017b6
@gartens @vogti
Fix typo
6ba2306
@gartens @vogti
Use O_EXCL to prevent races when creating the lock file
a50c13b
@gartens @vogti
Return early when $result is null
352892a
@gartens @vogti
Get current branch directly from Git
9751aeb
@gartens @vogti
Avoid indexing a null value
9b09df5
@gartens @vogti
Use user id for membership check
7d6e3ad
@gartens @vogti
Avoid deprecation warning
427b698 
Dynamically setting properties is deprecated, so give weeks a bit of a
special treatment.
@gartens @vogti
Make path checking in .htaccess files a bit stricter
1c8f803
@gartens @vogti
Read System::RESULTS again after convertResults
5de8af6 
Without this the default configuration created by convertResults won't
be displayed the first time the system page is shown after creating
a new system.
@gartens @vogti
Further improvements to .htaccess and default route
3702225
@gartens @vogti
Redirect user to index.php when installation was successful
a06447a
@gartens @vogti
Remove a leftover comment and add back a sleep call
3e34e4c
@vogti
Readd dies
977fc6a
@vogti
Adjust dies
68f1ca5
vogti
vogti approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @gartens, for this PR!

@vogti vogti merged commit 4b96de7 into Chronos-EaaS:master Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogti vogti vogti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gartens @vogti