Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: normalize variable names across caustics objects #302

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

ConnorStoneAstro
Copy link
Member

Update to get the naming conventions in line. Now all lenses defined with an Einstein radius use Rein. all lenses defined with a mass use mass. Other radii are defined with R___ such as the core radius which is Rc and scale radius which is Rs.

@ConnorStoneAstro ConnorStoneAstro added the refactor A code change that neither fixes a bug nor adds a feature label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 95.50562% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.35%. Comparing base (264b300) to head (165a17d).

Files with missing lines Patch % Lines
src/caustics/lenses/tnfw.py 70.00% 3 Missing ⚠️
src/caustics/lenses/nfw.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #302      +/-   ##
==========================================
+ Coverage   90.31%   90.35%   +0.03%     
==========================================
  Files          55       55              
  Lines        2281     2280       -1     
==========================================
  Hits         2060     2060              
+ Misses        221      220       -1     
Flag Coverage Δ
unittests 90.35% <95.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ConnorStoneAstro ConnorStoneAstro linked an issue Dec 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize variable names in caustics
1 participant