(hub, circles): personalMint should not revert, calculateIssuanceWith…

…Check

src/circles/Circles.sol

@@ -76,13 +76,11 @@ contract Circles is ERC1155 {
 
     // Public functions
 
-    // Internal functions
-
     /**
      * @notice Calculate the demurraged issuance for a human's avatar.
      * @param _human Address of the human's avatar to calculate the issuance for.
      */
-    function _calculateIssuance(address _human) internal view returns (uint256) {
+    function calculateIssuance(address _human) public view returns (uint256) {
         MintTime storage mintTime = mintTimes[_human];
         if (mintTime.mintV1Status != address(0) && mintTime.mintV1Status != CIRCLES_STOPPED_V1) {
             // Circles v1 contract cannot be active.
@@ -120,15 +118,17 @@ contract Circles is ERC1155 {
         return Math64x64.mulu(Math64x64.sub(T[n], overcount), EXA);
     }
 
+    // Internal functions
+
     /**
      * @notice Claim issuance for a human's avatar and update the last mint time.
      * @param _human Address of the human's avatar to claim the issuance for.
      */
     function _claimIssuance(address _human) internal {
-        uint256 issuance = _calculateIssuance(_human);
+        uint256 issuance = calculateIssuance(_human);
         if (issuance == 0) {
-            // No issuance to claim.
-            revert CirclesERC1155NoMintToIssue(_human, mintTimes[_human].lastMintTime);
+            // No issuance to claim, simply return without reverting
+            return;
         }
         // mint personal Circles to the human
         _mint(_human, toTokenId(_human), issuance, "");

src/errors/Errors.sol

@@ -38,8 +38,6 @@ interface IHubErrors {
 interface ICirclesERC1155Errors {
     error CirclesERC1155MintBlocked(address human, address mintV1Status);
 
-    error CirclesERC1155NoMintToIssue(address human, uint96 lastMintTime);
-
     error CirclesERC1155AmountExceedsMaxUint190(address account, uint256 circlesId, uint256 amount, uint8 code);
 }
 

src/hub/Hub.sol

@@ -368,15 +368,16 @@ contract Hub is Circles, MetadataDefinitions, IHubErrors, ICirclesErrors {
     }
 
     /**
-     * @notice Calculate issuance allows to calculate the issuance for a human avatar.
+     * @notice Calculate issuance allows to calculate the issuance for a human avatar with a check
+     * to update the v1 mint status if updated.
      * @param _human address of the human avatar to calculate the issuance for
      * @return issuance amount of Circles that can be minted
      */
-    function calculateIssuance(address _human) external returns (uint256) {
+    function calculateIssuanceWithCheck(address _human) external returns (uint256) {
         // check if v1 Circles is known to be stopped and update status
         _checkHumanV1CirclesStatus(_human);
         // calculate issuance for the human avatar, but don't mint
-        return _calculateIssuance(_human);
+        return calculateIssuance(_human);
     }
 
     /**

test/circles/MockCircles.sol

@@ -21,10 +21,6 @@ contract MockCircles is Circles {
         }
     }
 
-    function calculateIssuance(address _human) external view returns (uint256) {
-        return _calculateIssuance(_human);
-    }
-
     function claimIssuance() external {
         require(mintTimes[msg.sender].lastMintTime != 0, "Circles: Not registered");
         _claimIssuance(msg.sender);