Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBI won't issue if logged into shared wallet #529

Open
louilinn opened this issue Nov 3, 2022 · 5 comments
Open

UBI won't issue if logged into shared wallet #529

louilinn opened this issue Nov 3, 2022 · 5 comments
Assignees
Labels
a priority ★★☆ confusion 😕 Something is confusing the users

Comments

@louilinn
Copy link
Collaborator

louilinn commented Nov 3, 2022

Because of how the app is built, update() which issues UBI is only triggered when logged into the personal wallet. Businesses who mostly use their shared wallet might not change view to their personal wallet for months. This may result in the dead man's switch being triggered for the owner accounts of these shared wallets.

How to handle this remains to be decided.

@louilinn louilinn added the confusion 😕 Something is confusing the users label Nov 3, 2022
@louilinn
Copy link
Collaborator Author

louilinn commented Mar 7, 2023

This behavior is verified again.

@louilinn louilinn added the missing design ✂️ The issue cannot be worked on until the design is ready label Mar 10, 2023
@louilinn
Copy link
Collaborator Author

Possible "solution":
We could for example add a banner in SW dashboard
“You are logged into a shared wallet. Remember to regularly switch to your personal wallet to receive your UBI and keep your personal account alive.”
@triaslucia

@louilinn
Copy link
Collaborator Author

Estimate this for next sprint @louilinn (look at code)
If a lot of work we go with a design for this kind of reminder suggested above
/ Lucia

@louilinn
Copy link
Collaborator Author

Estimate: 3 (smaller task)
Suggested solution:

  1. Use state: safe.accounts,
  2. Filter out non org accounts (includes our personal wallet)
  3. Call UBI on those accounts (can in theory be several so use map, in practice it will be a list of one safe)
  4. Verify new behaviour

UBI call happens here:

const payout = await core.token.checkUBIPayout(safe.currentAccount);

@triaslucia
Copy link

We agree already on a process.
1.We will make the UBI be issued in the Individual Wallet, even when the person is on the SW.
2. The SW will get a notification. The notification text should be changed.

Design Material: https://www.figma.com/file/ZTqF54s6CSHTwAxp0U0JjQ/Circles-myxogastria?node-id=9213%3A21268&t=oz8Fo1HDJTjaNtqD-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a priority ★★☆ confusion 😕 Something is confusing the users
Projects
None yet
Development

No branches or pull requests

2 participants