Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gsoc'24): Timing Diagram increase decrease buttons #313

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix(gsoc'24): Timing Diagram increase decrease buttons #313

wants to merge 13 commits into from
+17 −20

Conversation

niladrix719
Copy link
Member

Fixes #107

Fixed Implementation of Timing Diagram increase decrease buttons

Screen.Recording.2024-05-16.at.7.40.45.PM.mov

@netlify Netlify
Copy link

netlify bot commented May 16, 2024 •
edited
Loading

✅ Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 49dc8c2
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/66ba1b44f357a900083135c6
😎 Deploy Preview https://deploy-preview-313--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Arnabdaz Arnabdaz added the hold label Jun 2, 2024
@niladrix719 niladrix719 added the GSOC'24 PR's for GSoC'24 label Jul 25, 2024
Arnabdaz
Arnabdaz requested changes Jul 27, 2024
View reviewed changes
Copy link
Member

@Arnabdaz Arnabdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the timing diagram to be disabled when there is no graph (flag in the circuit) no need to change the size of the window when its disabled.

@vedant-jain03
Copy link
Member

@niladrix719 have we fixed:

please update the timing diagram to be disabled when there is no graph (flag in the circuit) no need to change the size of the window when its disabled.

Please share the recording

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arnabdaz Arnabdaz Arnabdaz requested changes

@vedant-jain03 vedant-jain03 Awaiting requested review from vedant-jain03

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
GSOC'24 PR's for GSoC'24 hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge updates and bug fixes from the main CircuitVerse repository since the decoupling of the vue simulator.
3 participants
@niladrix719 @vedant-jain03 @Arnabdaz