Centralize bindgen #1136
Draft
Centralize bindgen #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to "newtype" enums
* Exposed:
- cl_set_clcb_msg()
- cl_cvdparse() and supporting symbols
- cl_debug()
- DB load/progress callback setting functions
- engine scan callbacks and types
- File file inspection callbacks and types
* Moved allowlisted funcs/types/variables to constants
* Updated bindgen dependency
…y-and-authors Update repository, authors, and copyright.
…epage-url Correct homepage URL
…authors Update authors
Merge the clamav-sys Rust crate into clamav, preserving history
shutton
force-pushed
the
centralize-bindgen
branch
from
7833532
to
076f236
Compare
shutton
force-pushed
the
centralize-bindgen
branch
4 times, most recently
from
f12c76d
to
376a21d
Compare
shutton
force-pushed
the
centralize-bindgen
branch
3 times, most recently
from
26b79f0
to
dba749a
Compare
Some builds using the tarball with the vendored Rust dependencies are failing. The onenote-rs dependency is presently tied to a git branch from github rather than using a release from crates.io. This is the differing factor though I'm unsure why it is causing the build to try to update the repo rather than just building the vendored source. This commit adds a `--offline` parameter to the build options if the vendored source is detected, in an attempt to force Cargo to use what it has and stay offline.
Export additional build context to Rust-based builds, and eliminate some of the duplicated logic when bulding a macOS univeral binary.
shutton
force-pushed
the
centralize-bindgen
branch
from
c5cecd4
to
1c8003b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize all use of bindgen (which exposes libclamav symbols to Rust code) into the clamav-sys module. libclamav_rust is no longer responsible for exporting internal symbols, and is focused only on exporting C-compatible symbols referencing code implemented in Rust.