Skip to content

Commit

Permalink
add zero address check in all initializers
Browse files Browse the repository at this point in the history
  • Loading branch information
brianendo authored and shuklaayush committed May 23, 2022
1 parent 3ee76b8 commit 76e25dd
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/BrickedStrategy.sol
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ contract BrickedStrategy is BaseStrategy {
/// @notice Proxies will set any non constant variable you declare as default value
/// @dev add any extra changeable variable at end of initializer as shown
function initialize(address _vault, address _want) public initializer {
require(_vault != address(0), "address 0 invalid");
require(_want != address(0), "address 0 invalid");
__BaseStrategy_init(_vault);
want = _want;
}
Expand Down
1 change: 1 addition & 0 deletions src/CitadelToken.sol
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ contract CitadelToken is GlobalAccessControlManaged, ERC20Upgradeable {
string memory _symbol,
address _gac
) public initializer {
require(_gac != address(0), "address 0 invalid");
__ERC20_init(_name, _symbol);
__GlobalAccessControlManaged_init(_gac);
}
Expand Down
6 changes: 6 additions & 0 deletions src/Funding.sol
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ contract Funding is GlobalAccessControlManaged, ReentrancyGuardUpgradeable {
address _citadelPerAssetOracle,
uint256 _assetCap
) external initializer {
require(_gac != address(0), "address 0 invalid");
require(_citadel != address(0), "address 0 invalid");
require(_asset != address(0), "address 0 invalid");
require(_xCitadel != address(0), "address 0 invalid");
require(_saleRecipient != address(0), "address 0 invalid");
require(_citadelPerAssetOracle != address(0), "address 0 invalid");
require(_saleRecipient != address(0), "Funding: 0 sale");
require(_citadelPerAssetOracle != address(0), "Funding: 0 oracle");

Expand Down
1 change: 1 addition & 0 deletions src/GlobalAccessControl.sol
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ contract GlobalAccessControl is
external
initializer
{
require(_initialContractGovernance != address(0), "address 0 invalid");
__AccessControlEnumerable_init();
__Pausable_init();

Expand Down
1 change: 1 addition & 0 deletions src/KnightingRound.sol
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ contract KnightingRound is
address _guestlist,
uint256 _tokenInLimit
) external initializer {
require(_globalAccessControl != address(0), "address 0 invalid");
require(
_saleStart >= block.timestamp,
"KnightingRound: start date may not be in the past"
Expand Down
1 change: 1 addition & 0 deletions src/KnightingRoundGuestlist.sol
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ contract KnightingRoundGuestlist is GlobalAccessControlManaged {
* `owner`.
*/
function initialize(address _globalAccessControl) public initializer {
require(_globalAccessControl != address(0), "address 0 invalid");
__GlobalAccessControlManaged_init(_globalAccessControl);
}

Expand Down
1 change: 1 addition & 0 deletions src/SupplySchedule.sol
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ contract SupplySchedule is GlobalAccessControlManaged, DSTest {
/// =======================

function initialize(address _gac) public initializer {
require(_gac != address(0), "address 0 invalid");
__GlobalAccessControlManaged_init(_gac);
_setEpochRates();
}
Expand Down

0 comments on commit 76e25dd

Please sign in to comment.