Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ETH/CTDL and BTC/CTDL chainlink provider #169

Merged
merged 5 commits into from
May 25, 2022
Merged

Add ETH/CTDL and BTC/CTDL chainlink provider #169

merged 5 commits into from
May 25, 2022

Conversation

shuklaayush
Copy link
Contributor

@shuklaayush shuklaayush commented May 24, 2022 •
edited
Loading

  • Uses BTC-ETH, WBTC-BTC and CTDL curve v2 pool's price_oracle to get ETH-CTDL price feed
  • Uses BTC-WBTC and CTDL curve v2 pool's price_oracle to get BTC-CTDL price feed

Addresses #140

@shuklaayush shuklaayush changed the title Add ETH/CTDL chainlink provider Add ETH/CTDL and BTC/CTDL chainlink provider May 24, 2022
@shuklaayush shuklaayush requested a review from sajanrajdev May 24, 2022 20:07
dapp-whisperer
dapp-whisperer approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@dapp-whisperer dapp-whisperer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs some tests so please create a separate issue for that

foundry.toml Show resolved Hide resolved
src/oracles/CtdlBtcChainlinkProvider.sol Outdated Show resolved Hide resolved
@sajanrajdev sajanrajdev mentioned this pull request May 24, 2022
Open
@shuklaayush shuklaayush merged commit d8c3dce into main May 25, 2022
@shuklaayush shuklaayush deleted the feat/eth-ctdl-oracle branch May 25, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapp-whisperer dapp-whisperer dapp-whisperer approved these changes

@sajanrajdev sajanrajdev Awaiting requested review from sajanrajdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuklaayush @dapp-whisperer