set options as default for new game #1705
Conversation
kianzarrin
added
Settings
| @@ -13,10 +13,15 @@ public static class MaintenanceTab_ConfigGroup { | |||
| Handler = OnReloadGlobalConfigClicked, | |||
| }; | |||
| public static ActionButton ResetGlobalConfig = new() { | |||
| Label = "Maintenance.Button:Reset global configuration", | |||
| Label = "Maintenance.Button:Reset all configuration", | |||
There was a problem hiding this comment.
? This will be super confusing for users.
1, they will ask what happened to reset global config button
2. they will ash what does "all" even mean.
There was a problem hiding this comment.
global is also not accurate because we are resetting defaults for new game too.
@krzychu124 what do you suggest I do?
There was a problem hiding this comment.
I'm not sure why you decided to save defaults in global config?
Global settings are user regardless of state but the defaults would be used only in specific condition which suggest that is not the best place for that.
Maybe we just need something like TMPE_DefaultGameSettings.xml created automatically, and then the user could even change things by hand? This way we could easily handle multiple versions of settings, e.g.: with popup with list of configs to use, similar to MoveIt Import/Export modal (it could simply overwrite the main file with selected one). That seem to be more future proof and most likely easier to manage.
There was a problem hiding this comment.
cool I create new file.
@krzychu124 but I still don't understand what should I call that button? should I split it into 2 buttons?
i mean its kind of global and currently there is no way for user to tell which settings are global except for trial and error (or read the xml files).
There was a problem hiding this comment.
hmm, maybe we need and icon or something to mark in-game specific options? I can be even ❔ button with a tooltip informing that setting is in-game only
There was a problem hiding this comment.
or maybe saved game options can have different text color in main menu.
@krzychu124 but I still don't understand what should I call that button? should I split it into 2 buttons?
There was a problem hiding this comment.
Leave it like it was "Global configuration" has its own meaning in the mod, wiki etc., always refers to GlobalConfig configuration file
TMPE.zip
fixes #363
fixes #1709
Resetting all configresets global config + sets default options for new games to built-in defaultsSet as default for new gamesoption was added. this can be pressed both in main menu and in game.Bonus:
SerializableUIOptionBaseresetAllparameter when resetting global was redundant - even misleading. so I dropped it. if theoldConfigparameter is null it is all reset (as it was the case before).