Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpdateFlags injection #174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

naeem76
Copy link

@naeem76 naeem76 commented Apr 4, 2020

PR for #101

I have just started looking into Cities modding, so apologies if there's any issue, I'm planning to contribute more if things go well.

Tested with 2 local instances of cities, and abandoned buildings were synced.

Copy link
Member

@kaenganxt kaenganxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution and sorry for taking so long to respond.
Your code looks good to me!
The build is failing because it looks like you forgot to add the changes of your CSM.csproj
Please add them to this PR.
I'll also test it out tomorrow.

@naeem76
Copy link
Author

naeem76 commented Apr 15, 2020

No probs on the time, I did some more testing afterwards, and in extreme scenarios it is a bit desynced, because server and client are doing their own thing, probably need to cancel any client side actions for these. I tried using harmony to skip original method when client side, but not working great. I'll check later when i have more time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants