Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace black/isort/flake8 with ruff #79

Merged
merged 9 commits into from
Jan 14, 2025
Merged

Replace black/isort/flake8 with ruff #79

merged 9 commits into from
Jan 14, 2025

Conversation

voneiden
Copy link
Contributor

@voneiden voneiden commented Jan 2, 2025

No description provided.

@voneiden voneiden changed the title Ruff Replace black/isort/flake8 with ruff Jan 2, 2025
@voneiden voneiden requested a review from a team January 2, 2025 12:34
@voneiden voneiden marked this pull request as ready for review January 2, 2025 12:34
Copy link
Contributor

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@voneiden voneiden requested a review from mhieta January 8, 2025 09:04
@voneiden
Copy link
Contributor Author

voneiden commented Jan 8, 2025

Added a couple of missing things still, @mhieta

@voneiden
Copy link
Contributor Author

voneiden commented Jan 8, 2025

Huh, am I still missing ruff from the requirements

Passing it as 4th argument to re.sub actually meant count=32

refs: RATYK-43
* oldapi.py
* helsinki.py
* manchester.py
* base.py
* athens.py

refs: RATYK-43
And add reminder to keep it in sync with .pre-commit-config.yaml
Copy link

sonarqubecloud bot commented Jan 9, 2025

Copy link
Contributor

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voneiden Good work!

@voneiden voneiden merged commit 7a4422c into master Jan 14, 2025
9 checks passed
@voneiden voneiden deleted the ruff branch January 14, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants