Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10555: Deprecated image style cleanup #624

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Dec 3, 2024

UHF-10555

What was done

  • Remove references to deprecated image style 3_2_m_2x that will be removed. This was apparently still left in the rekry custom module configuration but it has been fixed to the actual configuration that is used.

How to install

  • Make sure your instance is up and running on latest dev branch.
  • make fresh
  • Checkout this feature branch and make sure that helfi_platform config is running on correct branch.
    • git fetch && git checkout UHF-10555
    • composer require drupal/helfi_platform_config:dev-UHF-10555
  • Run make drush-cr drush-cim drush-updb

How to test

  • Testing for this might not be required since the code that was changed is not in active use since the core.entity_view_display.node.job_listing.default.yml file is read from the conf/cmi folder. You can compare the files to make sure that they are identical.
  • Check that code follows our standards.
  • Check testing instructions for the platform configuration changes from the UHF-10555: Deprecated image style cleanup drupal-helfi-platform-config#856 PR.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

Copy link

sonarcloud bot commented Dec 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant