Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-6294: Allow weight to be changed #131

Merged
merged 1 commit into from
Sep 14, 2023
Merged

UHF-6294: Allow weight to be changed #131

merged 1 commit into from
Sep 14, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Sep 14, 2023

See https://helsinkisolutionoffice.atlassian.net/browse/UHF-6294

How to install

  • composer require drupal/helfi_api_base:dev-UHF-6294

How to test

  • Make sure menu link's weight can be changed on TPR unit/service edit page

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #131 (fdf599d) into main (f5fab16) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head fdf599d differs from pull request most recent head a15cf27. Consider uploading reports for the commit a15cf27 to get more accurate results

@@             Coverage Diff              @@
##               main     #131      +/-   ##
============================================
- Coverage     64.17%   64.08%   -0.09%     
  Complexity      478      478              
============================================
  Files            66       66              
  Lines          1661     1668       +7     
============================================
+ Hits           1066     1069       +3     
- Misses          595      599       +4     
Files Changed Coverage Δ
src/Entity/Form/MenuLinkFormTrait.php 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hyrsky hyrsky self-requested a review September 14, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants