Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7324: Support deleting old revisions #133

Merged
merged 7 commits into from
Sep 18, 2023
Merged

UHF-7324: Support deleting old revisions #133

merged 7 commits into from
Sep 18, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Sep 15, 2023

How to install

  • composer require drupal/helfi_api_base:dev-UHF-7324
  • drush cr
  • Add this to your local.settings.php file:
$config['helfi_api_base.delete_revisions']['entity_types'] = [
  'node',
  'paragraph',
  'tpr_unit',
  'tpr_service',
  'tpr_errand_service',
];

How to test

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Merging #133 (d34d7a6) into main (f5fab16) will increase coverage by 1.61%.
Report is 5 commits behind head on main.
The diff coverage is 92.92%.

❗ Current head d34d7a6 differs from pull request most recent head a81bbf2. Consider uploading reports for the commit a81bbf2 to get more accurate results

@@             Coverage Diff              @@
##               main     #133      +/-   ##
============================================
+ Coverage     64.17%   65.79%   +1.61%     
- Complexity      478      505      +27     
============================================
  Files            66       69       +3     
  Lines          1661     1760      +99     
============================================
+ Hits           1066     1158      +92     
- Misses          595      602       +7     
Files Changed Coverage Δ
src/Entity/Form/MenuLinkFormTrait.php 0.00% <0.00%> (ø)
src/Commands/RevisionCommands.php 100.00% <100.00%> (ø)
src/Entity/Revision/RevisionManager.php 100.00% <100.00%> (ø)
src/Plugin/QueueWorker/RevisionQueue.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the commands and had a look at the code.

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants