-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticsearch connector plugin #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyrsky
force-pushed
the
UHF-10990
branch
2 times, most recently
from
November 20, 2024 17:07
62e9042
to
5324788
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
============================================
+ Coverage 89.11% 89.14% +0.03%
- Complexity 522 523 +1
============================================
Files 77 78 +1
Lines 2085 2091 +6
============================================
+ Hits 1858 1864 +6
Misses 227 227 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Quality Gate passedIssues Measures |
tuutti
approved these changes
Nov 21, 2024
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://helsinkisolutionoffice.atlassian.net/browse/UHF-10549.
Service addresses use self signed sertificate. To use them, we need to configure elasticsearch_connector module such that it accepts these sertificates.
How to test:
Run:
composer require drupal/helfi_api_base:dev-UHF-10990
.In infofinland, add
to
local.settings.php
.https://drupal-infofinland.docker.so/admin/config/search/search-api/server/default should die to certificate errors.
Change to
https://drupal-infofinland.docker.so/admin/config/search/search-api/server/default should not die. Should give error "The ElasticSearch cluster could not be reached. Further data is therefore unavailable." because 'https://self-signed.badssl.com/' is not elasticsearch server.