Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10969: Remove leading/trailing spaces #191

Merged
merged 1 commit into from
Nov 29, 2024
Merged

UHF-10969: Remove leading/trailing spaces #191

merged 1 commit into from
Nov 29, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Nov 28, 2024

UHF-10969

What was done

  • Added an update hook to remove non-breaking spaces, any leading or trailing %20 and spaces from link urls.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi API Base
    • composer require drupal/helfi_api_base:dev-UHF-10969
  • Run make drush-cr

How to test

  • Create a page with a set of broken links (ask @khalima or AI for a list of links with leading/trailing spaces, non-breaking spaces and %20.
  • Copy the links to any text field in any entity and save the entity
  • Verify that the links are broken by opening the entity in a browser window
  • Run make drush-updb drush-cr
  • Refresh the browser window and check that the links have been trimmed.
  • Check that code follows our standards

Other PRs

…ading or trailing and spaces from link urls.
Copy link

sonarcloud bot commented Nov 28, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.07%. Comparing base (d5d46f3) to head (9576a0e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #191      +/-   ##
============================================
- Coverage     89.14%   89.07%   -0.07%     
- Complexity      523      527       +4     
============================================
  Files            78       79       +1     
  Lines          2091     2106      +15     
============================================
+ Hits           1864     1876      +12     
- Misses          227      230       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants