fix: add support for inlining via ROLLUP_INLINE_DYNAMIC_IMPORTS #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting ROLLUP_INLINE_DYNAMIC_IMPORTS=true will essentially create a single js and css file. The reason for introducing this is that platta has implemented DDoS protection that gets easily upset because normal rollup build produces quite many js and css assets. This becomes very problematic with playwright tests that make a lot of repeated requests. refs: LINK-2229
|
LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr447-ui.dev.hel.ninja 🚀🚀🚀 |
danipran
approved these changes
Jan 17, 2025
e2e tests result is success for https://linkedcomponents-pr447-ui.dev.hel.ninja 😆🎉🎉🎉 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting ROLLUP_INLINE_DYNAMIC_IMPORTS=true will essentially create a single js and css file.
The reason for introducing this is that platta has implemented DDoS protection that gets easily upset because normal rollup build produces quite many js and css assets. This becomes very problematic with playwright tests that make a lot of repeated requests.
refs: LINK-2229
Co-PR: https://dev.azure.com/City-of-Helsinki/linkedevents/_git/linkedevents-pipelines/pullrequest/10597