Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: LINK-2191 cross-spawn #206

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mikkojamG
Copy link
Contributor

@mikkojamG mikkojamG commented Jan 15, 2025

Description ✨

  • cross-spawn is a subdependency of Eslint. Eslint can be upgraded to v9, this requires whole config overhaul: db547ab
  • Set cross-spawn to version 7.0.6 as a resolution for dependencies that cannot be upgraded atm.

Fixes vulnerability: https://github.com/City-of-Helsinki/linkedregistrations-ui/security/dependabot/55

Issues 🐛

Closes 🙅‍♀️

DEV-XXX:

Related 🤝

Testing ⚗️

Automated tests ⚙️️

Manual testing 👷‍♂️

Screenshots 📸

Additional notes 🗒️

@terovirtanen
Copy link
Contributor

LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr206-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedregistrations-pr206-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG force-pushed the deps/LINK-2191-cross-spawn branch from 1398563 to d636f27 Compare January 15, 2025 11:46
@terovirtanen
Copy link
Contributor

LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr206-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedregistrations-pr206-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG changed the title [DRAFT] Deps/link 2191 cross spawn [DRAFT] deps: LINK-2191 cross-spawn Jan 15, 2025
@mikkojamG mikkojamG changed the title [DRAFT] deps: LINK-2191 cross-spawn deps: LINK-2191 cross-spawn Jan 17, 2025
@mikkojamG mikkojamG force-pushed the deps/LINK-2191-cross-spawn branch 2 times, most recently from de5e7c2 to b8faa71 Compare January 17, 2025 06:05
@mikkojamG mikkojamG force-pushed the deps/LINK-2191-cross-spawn branch from b8faa71 to c9d6664 Compare January 17, 2025 06:06
@mikkojamG mikkojamG marked this pull request as ready for review January 17, 2025 06:06
@mikkojamG mikkojamG requested a review from a team January 17, 2025 06:06
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr206-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedregistrations-pr206-ui.dev.hel.ninja 😆🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants