HP-2266 | fix: handle updates profile's language and contact_method fields #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In graphene 3 when Enum's are used as an input to a field the resolver now receives the Enum member directly rather than the value. This was a breaking change that wasn't taken into account when upgrading to the new graphene major version. Refs: HP-2266, https://github.com/graphql-python/graphene/wiki/v3-release-notes#better-enum-support
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
- Coverage 95.56% 95.49% -0.07%
==========================================
Files 207 207
Lines 8222 8263 +41
Branches 991 998 +7
==========================================
+ Hits 7857 7891 +34
- Misses 279 286 +7
Partials 86 86 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In graphene 3 when Enum's are used as an input to a field the resolver now receives the Enum member directly rather than the value. This was a breaking change that wasn't taken into account when upgrading to the new graphene major version.