Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: matomo cookieless tracking PL-5 #1201

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

mikkojamG
Copy link
Contributor

@mikkojamG mikkojamG commented Nov 18, 2024

  • Replace @datapunt/matomo-tracker-js with MatomoTracker class.
  • Cookieless tracking enabled untill user either accepts or denies tracking cookies.

Azure UI config changes PR
https://dev.azure.com/City-of-Helsinki/palvelukartta/_git/palvelukartta-pipelines/pullrequest/10209

@mikkojamG mikkojamG force-pushed the feat/PL-5-matomo-cookieless-tracking branch 2 times, most recently from 65056b8 to 044a14a Compare November 18, 2024 11:07
@mikkojamG mikkojamG changed the title [DRAFT] feat: matomo cookieless tracking PL-5 feat: matomo cookieless tracking PL-5 Nov 18, 2024
@mikkojamG mikkojamG marked this pull request as ready for review November 18, 2024 13:29
@mikkojamG mikkojamG requested a review from a team November 18, 2024 13:29
@mikkojamG mikkojamG force-pushed the feat/PL-5-matomo-cookieless-tracking branch from 044a14a to bd3a184 Compare November 28, 2024 10:16
Copy link
Contributor

@japauliina japauliina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MATOMO_ENABLED could also be added to .env.example.

@mikkojamG
Copy link
Contributor Author

MATOMO_ENABLED could also be added to .env.example.

Added: 1d84d19

Copy link
Contributor

@japauliina japauliina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@mhieta mhieta merged commit 84746f1 into develop Nov 29, 2024
3 checks passed
@mhieta mhieta deleted the feat/PL-5-matomo-cookieless-tracking branch November 29, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants